Refactor ExampleBrowser #10
Conversation
- navigate between examples with react-router (each example has got a slug) - extract ExampleViewer into a separate component, determine its size using react-sizeme - make ExampleBrowser component functional (i.e. pure)
| @@ -20,6 +20,8 @@ | |||
| "cannon": "^0.6.2", | |||
| "react": "~15.3.1", | |||
| "react-dom": "^15.3.1", | |||
| "react-router": "^3.0.0-alpha.3", | |||
There was a problem hiding this comment.
using 3.0 instead of 2.* because of remix-run/react-router#3611 (comment)
|
Thank you for the PR, I think I will probably go with firtoz/react-three-renderer#82 but have not had the time to make a decision yet |
|
I agree that using the storybook would be much better. This PR can be a temporal patch until that idea has turned into code. I found it quite inconvenient not to have permalinks for examples while refreshing the app, so mainly fixing just this. |
|
good point! |
|
ping :–) |
|
Hi, apologies for the lateness, I have been having issues with my internet I will go to a coffee shop sometime this week with my laptop to merge, test Firtina On Fri, 23 Sep 2016, 16:07 Alexander Kachkaev, [email protected]
|
(each example has got a slug)
determine its size using react-sizeme