Skip to content

Commit

Permalink
Add more conflict types to ConflictFinder (#238)
Browse files Browse the repository at this point in the history
## 📝 Summary

Add more conflict types to `ConflictFinder` as per
[#226](#226)

## A brief overview of the changes:
- I added multiple new mapping entries to `ConflictFinder`, namely 
```rust     
    group_balance_reads: HashMap<Address, Vec<usize>>,
    group_balance_writes: HashMap<Address, Vec<usize>>,
    group_contract_creations: HashMap<Address, Vec<usize>>,
    group_contract_destructions: HashMap<Address, Vec<usize>>,
```
- Added conflicts that can be related to those fields
- Added `combine_groups` - a utility fn to reuse code
- Added `ConflictFinder.add_group_to_index` and
`ConflictFinder.remove_group_from_index` to reuse code and improve
readability; `index` here means search index, or different member
mappings of `ConflictFinder`

---

## ✅ I have completed the following steps:

* [x] Run `make lint`
* [X] Run `make test`
* [X] Added tests (if applicable)

---------

Co-authored-by: dev <[email protected]>
  • Loading branch information
grasphoper and dev authored Dec 12, 2024
1 parent 17776cc commit 16290b6
Showing 1 changed file with 359 additions and 116 deletions.
Loading

0 comments on commit 16290b6

Please sign in to comment.