Rbuilder-inprocess receive txns from Reth #295
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferranbt
requested review from
dvush,
ZanCorDX and
liamaharon
as code owners
Benchmark results for
|
| Date (UTC) | 2024-12-18T16:24:49+00:00 |
| Commit | 9060ba6415e1da082724a2eee4640f8df52ae45f |
| Base SHA | 2e4c1ab8bc46e6110ef58fe39ac46160f6a7abbe |
Significant changes
| Benchmark | Mean | Status |
|---|---|---|
| gather_nodes_account_trie | 2.62% | Performance has degraded. |
| ptr_trie_insert_only_3000 | 2.60% | Performance has degraded. |
| gather_nodes_big_changes_account | 2.44% | Performance has degraded. |
| MEV-Boost SubmitBlock serialization/JSON encoding | -36.63% | Performance has improved. |
| gather_nodes_empty_account | -25.15% | Performance has improved. |
ZanCorDX
approved these changes
Dec 19, 2024
ZanCorDX
reviewed
Dec 19, 2024
Comment on lines
+87
to
+91
| let ipc_path = if ctx.config().rpc.is_ipc_enabled() { | ||
| Some(PathBuf::from(ctx.config().rpc.ipc_path())) | ||
| } else { | ||
| None | ||
| }; |
There was a problem hiding this comment.
Can you move this insde spawn_rbuilder or as a func to avoid more copy/paste?
There was a problem hiding this comment.
Moved it to draft, it did not show the improvement I was expecting. I have to debug more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fixes #293
This PR overrides the IPC rbuilder config with the one used by the Reth node.
✅ I have completed the following steps:
make lintmake test