Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add ScreenCast source type meaning #1347

Merged

Conversation

tytan652
Copy link
Contributor

@tytan652 tytan652 commented Apr 22, 2024

The name "virtual" is too ambiguous by itself so a blurb is added for each type.

@tytan652 tytan652 force-pushed the virtual_is_only_about_monitor branch from 64c9370 to 50c508f Compare April 22, 2024 21:39
@swick
Copy link
Contributor

swick commented Oct 4, 2024

Does virtual really mean virtual monitors here? What's the use case? @jadahl

@jadahl
Copy link
Collaborator

jadahl commented Oct 4, 2024

Does virtual really mean virtual monitors here? What's the use case? @jadahl

Yes it does. The use case to get a "virtual monitor" that extends your current session. E.g. Miracast as a separate output.

@swick
Copy link
Contributor

swick commented Oct 4, 2024

Maybe add a blurb to the other variants as well. But in general this LGTM then.

@tytan652 tytan652 force-pushed the virtual_is_only_about_monitor branch from 50c508f to 1099c8d Compare October 4, 2024 12:59
@tytan652
Copy link
Contributor Author

tytan652 commented Oct 4, 2024

@swick added blurb for each type.

@tytan652 tytan652 force-pushed the virtual_is_only_about_monitor branch from 1099c8d to 048947d Compare October 4, 2024 13:13
@tytan652 tytan652 changed the title doc: Add virtual ScreenCast type meaning doc: Add ScreenCast source type meaning Oct 4, 2024
The name "virtual" is too ambiguous by itself so a blurb is added for
each type.
@tytan652 tytan652 force-pushed the virtual_is_only_about_monitor branch from 048947d to 4f88fa7 Compare October 4, 2024 17:47
@GeorgesStavracas GeorgesStavracas added the portal: screencast Screencast portal label Oct 5, 2024
@GeorgesStavracas GeorgesStavracas added this to the 1.20 milestone Oct 5, 2024
@GeorgesStavracas GeorgesStavracas added this pull request to the merge queue Oct 5, 2024
Merged via the queue into flatpak:main with commit 53bbf4b Oct 5, 2024
4 checks passed
@tytan652 tytan652 deleted the virtual_is_only_about_monitor branch October 5, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
portal: screencast Screencast portal
Projects
Status: Triaged
Development

Successfully merging this pull request may close these issues.

4 participants