FOGL-8507 : Taken care of quotes and slash in asset name #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nandan <[email protected]>
Signed-off-by: nandan <[email protected]>
gnandan
requested review from
MarkRiddoch,
Innovative-ashwin and
AmandeepArora
MarkRiddoch
reviewed
Sep 30, 2024
I executed system tests, lab scripts using CI Jobs and did some manual testing. Please refer following sheet for detailed report https://docs.google.com/spreadsheets/d/1brHU_U5kCGqKkUxm5igvvu_SPYjmtuDHRDpIQxy3ZE8/edit?usp=sharing |
MarkRiddoch
reviewed
Nov 29, 2024
C/common/string_utils.cpp
Outdated
| * @param StringReplicate substitution string | ||
| * | ||
| */ | ||
| void replicate(std::string& StringToManage, |
There was a problem hiding this comment.
Replicate is a bad name for this. Probably replaceAll us better
There was a problem hiding this comment.
Here function is replicating a single character to double character. Also StringReplaceAll function is already there but will not work in this scenario. That's why I created new function. I will rename the function as StringReplaceAllEx to make it more intuitive.
Signed-off-by: nandan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.