Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @okta/oidc-middleware from 4.0.1 to 5.0.0 in /ee/vulnerability-dashboard #17601

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 13, 2024

Bumps @okta/oidc-middleware from 4.0.1 to 5.0.0.

Release notes

Sourced from @​okta/oidc-middleware's releases.

5.0.0

Breaking Changes

4.5.1

Bug Fixes

  • #43 fix: correctly preprends appBaseUrl to redirect url when appBaseUrl contains a base path

4.5.0

Features

  • #40 Allows passing loginHint to ensureAuthenticated

Bug Fixes

  • #42 Fixes appBaseUrl option not prepending to login redirect url

4.4.0

Bug Fixes

  • #34 Fixes Org AS login issue
  • #3 Call res.redirect() after custom routes.loginCallback.handler
  • #37 fix: .logout no longer throws error without valid credentials
Changelog

Sourced from @​okta/oidc-middleware's changelog.

5.0.0

Breaking Changes

4.6

-#53 Fix: prevents open redirects

4.5.1

Bug Fixes

  • #43 fix: correctly preprends appBaseUrl to redirect url when appBaseUrl contains a base path

4.5.0

Features

  • #40 Allows passing loginHint to ensureAuthenticated

Bug Fixes

  • #42 Fixes appBaseUrl option not prepending to login redirect url

4.4.0

Bug Fixes

  • #34 Fixes Org AS login issue
  • #3 Call res.redirect() after custom routes.loginCallback.handler
  • #37 fix: .logout no longer throws error without valid credentials

4.3.0

Other

  • Release after migrating from monorepo

4.2.0

Bug Fixes

  • #1020 Fixes issue with UUID returning null

4.1.0

Features

... (truncated)

Commits
  • 50c093b chore(deps): upgrade vulnerable dependencies (#54)
  • 5d10b3c Prevent open redirects (#53)
  • fe24bfc chore: Update dependencies
  • ebafab4 chore: dev dependency upgrades
  • 113e1a3 chore: updates github issue template
  • a9b6ad2 Merge remote-tracking branch 'origin/4.5' into sw-backport-4.5.1
  • 8b0691c fix: if appBaseUrl includes a base path
  • 94852df Releng: Revving up to version(s) 4.6.0 for artifact(s) None
  • 4e1414e fixes: 'appBaseUrl' option not prepended to login redirect url
  • 9c5e3b0 feat: allow passing loginHint option to ensureAuthenticated
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [@okta/oidc-middleware](https://github.com/okta/okta-oidc-middleware) from 4.0.1 to 5.0.0.
- [Release notes](https://github.com/okta/okta-oidc-middleware/releases)
- [Changelog](https://github.com/okta/okta-oidc-middleware/blob/master/CHANGELOG.md)
- [Commits](https://github.com/okta/okta-oidc-middleware/compare/@okta/[email protected])

---
updated-dependencies:
- dependency-name: "@okta/oidc-middleware"
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added javascript Pull requests that update Javascript code ~dependencies Pull requests that update a dependency file labels Mar 13, 2024
@lukeheath lukeheath requested a review from eashaw March 21, 2024 14:55
@lukeheath
Copy link
Member

@eashaw Please try upgrading this package. This one may require code changes since it's a major version update.

Copy link
Contributor

@eashaw eashaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the vulnerability dashboard with this updated package, and all SSO behavior works as expected/the same.

@eashaw eashaw merged commit 94da1ec into main Mar 21, 2024
4 checks passed
@eashaw eashaw deleted the dependabot/npm_and_yarn/ee/vulnerability-dashboard/okta/oidc-middleware-5.0.0 branch March 21, 2024 17:17
@eashaw
Copy link
Contributor

eashaw commented Mar 21, 2024

Correction on the above, I was mistakenly testing the Okta SSO flows with the wrong branch checked out. This change introduces an error thrown by an updated child dependency of this package when a request is sent to a static asset in the ./public folder.

I tested changing the middleware's order to have the middleware that serves static public assets before the Okta SSO middleware, and that resolved the issue. I'm creating an issue and PR to resolve this and will wait until this is merged and QA'd to deploy a new version to customer deployments.
cc: @lukeheath

eashaw added a commit that referenced this pull request Mar 22, 2024
Closes: #17772
More context:
#17601 (comment)

Changes: 
- Updated the order of the vulnerability dashboard's HTTP middleware if
Okta SSO is enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
~dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Development

Successfully merging this pull request may close these issues.

2 participants