-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mastodon link to server email templates #23309
Conversation
jc0b
commented
Oct 28, 2024
- Adds a link to FleetDM's Mastodon account to emails sent by the FleetDM server
- Adds a Mastodon SVG image to the repo
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #23309 +/- ##
=======================================
Coverage 63.57% 63.57%
=======================================
Files 1602 1602
Lines 151786 151786
Branches 3916 3952 +36
=======================================
Hits 96498 96498
+ Misses 47608 47607 -1
- Partials 7680 7681 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@rachaelshaw Looking like this is waiting on feedback from you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(See comments for requested changes)
Found out as part of #24506 that we actually need to put this logo in
? With those changes, we should be good to merge here. Thanks! |
One more thing: please add a changes file (similar to the one I included in the PR I linked in my last comment) to note that the Mastodon link got added. That's non-blocking feedback though; I'll hop in and add it if you don't. |
Ok, this should be done now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; thanks! Will merge this, wait for the image to deploy, then confirm that emails have the logo in them.
Awesome, thanks for all the help with this!On 17 Dec 2024, at 06:00, Ian Littman ***@***.***> wrote:
It works!
image.png (view on web)
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|