Use goreleaser v2 in CI #23748
Use goreleaser v2 in CI #23748
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #23748 +/- ##
========================================
Coverage 63.44% 63.44%
========================================
Files 1582 1578 -4
Lines 150371 150025 -346
Branches 3805 3612 -193
========================================
- Hits 95405 95189 -216
+ Misses 47369 47243 -126
+ Partials 7597 7593 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sgress454
requested review from
lukeheath,
georgekarrv,
sharon-fdm and
a team
as code owners
| version: "~> 1" | ||
| args: release --rm-dist -f .goreleaser.yml | ||
| version: "~> 2" | ||
| args: release --clean -f .goreleaser.yml |
There was a problem hiding this comment.
| run: go run github.com/goreleaser/goreleaser@56c9d09a1b925e2549631c6d180b0a1c2ebfac82 release --debug --rm-dist --skip-publish -f orbit/goreleaser-macos.yml # v1.20.0 | ||
| run: go run github.com/goreleaser/goreleaser/v2@606c0e724fe9b980cd01090d08cbebff63cd0f72 release --verbose --clean --skip=publish -f orbit/goreleaser-macos.yml # v1.20.0 |
There was a problem hiding this comment.
There was a problem hiding this comment.
You should update the version comment (# v1.20.0) to reflect what new version this git hash 606c0e724fe9b980cd01090d08cbebff63cd0f72 refers to.
| name_template: "{{ .Tag }}-untagged" | ||
| version_template: "{{ .Tag }}-untagged" |
There was a problem hiding this comment.
| skip: true | ||
| disable: true |
There was a problem hiding this comment.
| run: go run github.com/goreleaser/goreleaser@56c9d09a1b925e2549631c6d180b0a1c2ebfac82 release --debug --rm-dist --skip-publish -f orbit/goreleaser-macos.yml # v1.20.0 | ||
| run: go run github.com/goreleaser/goreleaser/v2@606c0e724fe9b980cd01090d08cbebff63cd0f72 release --verbose --clean --skip=publish -f orbit/goreleaser-macos.yml # v1.20.0 |
There was a problem hiding this comment.
You should update the version comment (# v1.20.0) to reflect what new version this git hash 606c0e724fe9b980cd01090d08cbebff63cd0f72 refers to.
|
|
||
| - name: Run GoReleaser | ||
| run: go run github.com/goreleaser/goreleaser@56c9d09a1b925e2549631c6d180b0a1c2ebfac82 release --debug --rm-dist --skip-publish -f orbit/goreleaser-linux.yml # v1.20.0 | ||
| run: go run github.com/goreleaser/goreleaser/v2@606c0e724fe9b980cd01090d08cbebff63cd0f72 release --verbose --clean --skip=publish -f orbit/goreleaser-linux.yml # v1.20.0 |
There was a problem hiding this comment.
Same here for the version comment (and elsewhere where the hash was changed).
There was a problem hiding this comment.
good catch, thanks! fixed.
| @@ -53,7 +53,6 @@ require ( | |||
| github.com/google/go-cmp v0.6.0 | |||
| github.com/google/go-github/v37 v37.0.0 | |||
| github.com/google/uuid v1.6.0 | |||
| github.com/goreleaser/goreleaser v1.1.0 | |||
There was a problem hiding this comment.
I assume those changes are from go mod tidy? If so those should be fine.
|
@sgress454 This has some conflicts now but otherwise looks ready to merge. |
@lukeheath someone needs to approve it as well 😉 |
for #19530
Replaces #23703, which had a bunch of dependency updates and code changes that I suspect aren't needed because we don't actually use goreleaser in any code, only in CI.
This PR updates Goreleaser to version 2 in CI usage. Updates include:
I was able to run the Docker Publish workflow successfully on this branch. The Orbit workflow ran successfully as well.