Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-Pick: Include expiration info, drop "personalized", in MFA email #24635

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

iansltx
Copy link
Member

@iansltx iansltx commented Dec 11, 2024

For #22078. Merged into main via #24630.

For #22078.

# Checklist for submitter

- [x] Manual QA for all new/changed functionality
@iansltx iansltx merged commit 470e07f into rc-minor-fleet-v4.61.0 Dec 11, 2024
12 checks passed
@iansltx iansltx deleted the cherry-pick-mfa-email-fixes branch December 11, 2024 01:02
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (rc-minor-fleet-v4.61.0@29a8d1a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/mail/mfa.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.61.0   #24635   +/-   ##
=========================================================
  Coverage                          ?   63.52%           
=========================================================
  Files                             ?     1590           
  Lines                             ?   150860           
  Branches                          ?     3767           
=========================================================
  Hits                              ?    95834           
  Misses                            ?    47383           
  Partials                          ?     7643           
Flag Coverage Δ
backend 64.37% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants