-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fleet UI: Allow select target search for labels and teams #24798
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24798 +/- ##
==========================================
- Coverage 54.28% 54.25% -0.03%
==========================================
Files 1601 1603 +2
Lines 151676 151849 +173
Branches 3952 4017 +65
==========================================
+ Hits 82334 82389 +55
- Misses 62546 62661 +115
- Partials 6796 6799 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this devnote say "above" the limit? Is it saying "if any team/labels are selected that would be truncated, default to showing all of the things" ? If so, it is working like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! Shared some thoughts on potential optimizations / style considerations
Issue
Cerra #22448
Description
TODO
Tests
Screenshot/screen recording
Note: This screenrecording had a character limit of 100 set for demo purposes, changed it to 600
https://github.com/user-attachments/assets/31578d10-214a-4812-af89-33403946ff58
changes/
,orbit/changes/
oree/fleetd-chrome/changes
.