Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSVL: update activities to add labels include/exclude (backend changes) #24839

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

mna
Copy link
Member

@mna mna commented Dec 17, 2024

#24792 (backend changes only)

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated tests

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 82.85714% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat-labels-scoped-software@79ac8fa). Learn more about missing BASE report.

Files with missing lines Patch % Lines
ee/server/service/software_installers.go 80.32% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##             feat-labels-scoped-software   #24839   +/-   ##
==============================================================
  Coverage                               ?   63.68%           
==============================================================
  Files                                  ?     1603           
  Lines                                  ?   152296           
  Branches                               ?     3952           
==============================================================
  Hits                                   ?    96987           
  Misses                                 ?    47567           
  Partials                               ?     7742           
Flag Coverage Δ
backend 64.48% <82.85%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mna mna marked this pull request as ready for review December 17, 2024 21:38
@mna mna requested review from rachaelshaw and a team as code owners December 17, 2024 21:38
@mna mna merged commit 14fc86d into feat-labels-scoped-software Dec 18, 2024
24 checks passed
@mna mna deleted the mna-24786-ssvl-activities branch December 18, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants