Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handbook: make sure changes outside of product groups are QA'd #24847

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Handbook: make sure changes outside of product groups are QA'd #24847

merged 4 commits into from
Dec 18, 2024

Conversation

noahtalerman
Copy link
Member

@noahtalerman
Copy link
Member Author

FYI @zayhanlon

lukeheath
lukeheath previously approved these changes Dec 17, 2024
View reviewed changes
@lukeheath
Copy link
Member

Yep that's my bad. I removed the #g-endpoint-ops label because it had been sitting in waiting for a long time. But I see that drawback of doing that now.

@noahtalerman
Copy link
Member Author

Yep that's my bad. I removed the #g-endpoint-ops label because it had been sitting in waiting for a long time. But I see that drawback of doing that now.

Ah, that's what happened. No worries!

@lukeheath lukeheath merged commit 61038bf into main Dec 18, 2024
4 checks passed
@lukeheath lukeheath deleted the noahtalerman-patch-18 branch December 18, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeheath lukeheath lukeheath approved these changes

Assignees
No one assigned
Labels
#handbook
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noahtalerman @lukeheath @fleet-release