Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary validation before secret expansion #24903

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

dantecatalfamo
Copy link
Member

@dantecatalfamo dantecatalfamo commented Dec 19, 2024

#24549

Remove redundant code introduced in original PR #24624

@dantecatalfamo dantecatalfamo marked this pull request as ready for review December 19, 2024 15:37
@dantecatalfamo dantecatalfamo requested a review from a team as a code owner December 19, 2024 15:37
Copy link
Member

@getvictor getvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, assuming tests pass.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.58%. Comparing base (0065c92) to head (e4eda79).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24903      +/-   ##
==========================================
+ Coverage   63.57%   63.58%   +0.01%     
==========================================
  Files        1603     1603              
  Lines      152009   152006       -3     
  Branches     3924     3924              
==========================================
+ Hits        96640    96659      +19     
+ Misses      47670    47650      -20     
+ Partials     7699     7697       -2     
Flag Coverage Δ
backend 64.39% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantecatalfamo dantecatalfamo merged commit dd5cbf6 into main Dec 19, 2024
25 checks passed
@dantecatalfamo dantecatalfamo deleted the fleet-secrets-expand-without-validate branch December 19, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants