Added secret variables support for DDM. #24969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func Up_20241220114903(tx *sql.Tx) error { | ||
| _, err := tx.Exec(` | ||
| ALTER TABLE mdm_apple_declarations | ||
| CHANGE raw_json raw_json MEDIUMTEXT COLLATE utf8mb4_unicode_ci NOT NULL -- 16MB max size`) |
There was a problem hiding this comment.
In case the user substitutes the secret outside of a string I presume? Could you just add a small comment explaining that change for future reference?
There was a problem hiding this comment.
Yes, like:
"Payload": {
"RequireAlphanumericPasscode": true,
"MinimumLength": $FLEET_SECRET_PASSCODE_LENGTH,
dantecatalfamo
approved these changes
Dec 20, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24969 +/- ##
==========================================
- Coverage 63.58% 63.57% -0.01%
==========================================
Files 1606 1607 +1
Lines 152219 152235 +16
Branches 3878 3878
==========================================
- Hits 96785 96784 -1
- Misses 47729 47742 +13
- Partials 7705 7709 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#24548 Adding secret variables support for DDM profiles.
Checklist for submitter
COLLATE utf8mb4_unicode_ci).