Feature: Scope Fleet-maintained apps and custom packages via labels #24976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Related issue: #24534 # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [x] Added/updated tests - [x] Manual QA for all new/changed functionality
…els (#24793) relates to #24538, #24542, #24540, #24537 implements the UI for scoping software to fleet maintained apps and custom packages. This includes: **adding custom target label selection to fleet maintained app form** <img width="824" alt="image" src="https://github.com/user-attachments/assets/b0e18841-e5c5-406a-b83f-ce2b5a8f8472" /> **adding custom target label selection to custom package form** <img width="821" alt="image" src="https://github.com/user-attachments/assets/06279121-69bd-4663-aebd-930cd7c02190" /> ***adding custom target label selection on edit software modals** <img width="796" alt="image" src="https://github.com/user-attachments/assets/c15a8236-1b02-4d17-9245-e24967190eaf" /> also includes various small copy changes. - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. - [ ] Added/updated tests - [x] Manual QA for all new/changed functionality
#24843) > Related issue: #24533 - We're still running the policy, but in the handler for the results we check if the software is in label scope. If not, we set the policy to be "undetermined" and we do not add an installation request - Added checks for label scoping to the "install software" and "self service install" endpoints # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files) for more information. - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [x] Added/updated tests - [x] Manual QA for all new/changed functionality
> Related issue: #24646 # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Added/updated tests
Co-authored-by: Jahziel Villasana-Espinoza <[email protected]>
…bels feature (#24888) relates to #24828, #24792 This updates the UI activities software including a new software details show details modal: <img width="825" alt="image" src="https://github.com/user-attachments/assets/3dd3019b-c94c-427b-9c52-d678a311c4bc" /> It also includes tests and api integration work for the creating and reading of scoped software via labels. > NOTE: still need to do the editing which we can do in another PR when the API is ready. - [x] Added/updated tests - [x] Manual QA for all new/changed functionality
relates to #24828 Finish up the UI integration for the API to edit a custom package - [x] Manual QA for all new/changed functionality
relates to #24537 updates the delete label error when label is used for software - [x] Manual QA for all new/changed functionality
Co-authored-by: Jahziel Villasana-Espinoza <[email protected]>
…24963) > Issue found during testing # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [x] Added/updated tests - [x] Manual QA for all new/changed functionality
gillespi314
had a problem deploying
to
Docker Hub
GitHub Actions
Error
gillespi314
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24976 +/- ##
==========================================
+ Coverage 63.57% 63.74% +0.17%
==========================================
Files 1607 1610 +3
Lines 152300 153167 +867
Branches 3967 3962 -5
==========================================
+ Hits 96822 97643 +821
+ Misses 47762 47735 -27
- Partials 7716 7789 +73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jahzielv
approved these changes
Dec 20, 2024
marko-lisica
approved these changes
Dec 23, 2024
ghernandez345
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #22813
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)COLLATE utf8mb4_unicode_ci).