Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a confirmation mechanism to notify users when the Fleet agent successfully installed on Windows. #24987

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

parsimeikoikai
Copy link

@parsimeikoikai parsimeikoikai commented Dec 23, 2024

Fix fo #21980

Checklist for submitter

  • For Orbit and Fleet Desktop changes:
    • Orbit runs on macOS, Linux and Windows. Check if the orbit feature/bugfix should only apply to one platform (runtime.GOOS).
    • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.

…s successfully installed on Windows.

This improves user feedback and aligns with behavior on macOS.
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.58%. Comparing base (e78bf6e) to head (aec043a).
Report is 69 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #24987      +/-   ##
==========================================
+ Coverage   63.56%   63.58%   +0.01%     
==========================================
  Files        1602     1607       +5     
  Lines      151820   152255     +435     
  Branches     3952     3952              
==========================================
+ Hits        96511    96814     +303     
- Misses      47624    47727     +103     
- Partials     7685     7714      +29     
Flag Coverage Δ
backend 64.38% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant