Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore UI update setup experience copy #25000

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

ghernandez345
Copy link
Contributor

@ghernandez345 ghernandez345 commented Dec 23, 2024

relates to #25001

quick updates to some of the UI copy on the setup experience add software modal and the software details modal for the software activities.

  • Manual QA for all new/changed functionality

@ghernandez345 ghernandez345 requested a review from a team as a code owner December 23, 2024 22:35
@ghernandez345 ghernandez345 self-assigned this Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 63.75%. Comparing base (38fcc30) to head (059c057).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...ents/SoftwareDetailsModal/SoftwareDetailsModal.tsx 8.33% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #25000   +/-   ##
=======================================
  Coverage   63.75%   63.75%           
=======================================
  Files        1610     1610           
  Lines      153169   153166    -3     
  Branches     3962     4012   +50     
=======================================
+ Hits        97654    97658    +4     
+ Misses      47729    47721    -8     
- Partials     7786     7787    +1     
Flag Coverage Δ
frontend 53.43% <8.33%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghernandez345 ghernandez345 force-pushed the chore-ui-update-setup-experience-copy branch from 6912eba to 059c057 Compare December 23, 2024 22:45
/>
)}
<DataSet
title="Target"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Targets" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

figma has it as "Target".

@ghernandez345 ghernandez345 merged commit 328a194 into main Dec 23, 2024
14 checks passed
@ghernandez345 ghernandez345 deleted the chore-ui-update-setup-experience-copy branch December 23, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants