bug repro with dedupe=true (#253)

* bug repro * chore: add two more assertions * chore: write test to explain problem * fix: dont try to copy a non-existant value into others --------- Co-authored-by: Simon Knott <[email protected]>
flightcontrolhq · Sep 27, 2023 · a8949df · a8949df
1 parent ff9cc2d
commit a8949df
Show file tree

Hide file tree

Showing 4 changed files with 82,817 additions and 7 deletions.
diff --git a/src/index.test.ts b/src/index.test.ts
@@ -1,6 +1,8 @@
 /* eslint-disable es5/no-for-of */
 /* eslint-disable es5/no-es6-methods */
 
+import * as fs from 'fs';
+
 import SuperJSON from './';
 import { JSONValue, SuperJSONResult, SuperJSONValue } from './types';
 import {
@@ -1193,3 +1195,24 @@ test('dedupe=true', () => {
 
   expect(instance.deserialize(output)).toEqual(input);
 });
+
+test('dedupe=true on a large complicated schema', () => {
+  const content = fs.readFileSync(__dirname + '/non-deduped-cal.json', 'utf-8');
+  const parsed = JSON.parse(content);
+
+  const deserialized = SuperJSON.deserialize(parsed);
+
+  const nondeduped = new SuperJSON({});
+
+  const deduped = new SuperJSON({
+    dedupe: true,
+  });
+
+  const nondedupedOut = nondeduped.deserialize(
+    nondeduped.serialize(deserialized)
+  );
+  const dedupedOut = deduped.deserialize(deduped.serialize(deserialized));
+
+  expect(nondedupedOut).toEqual(deserialized);
+  expect(dedupedOut).toEqual(deserialized);
+});
diff --git a/src/index.ts b/src/index.ts
@@ -45,7 +45,8 @@ export default class SuperJSON {
     }
 
     const equalityAnnotations = generateReferentialEqualityAnnotations(
-      identities
+      identities,
+      this.dedupe
     );
     if (equalityAnnotations) {
       res.meta = {