Local storage context #315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Read's plugin settings from disk once, then makes in-memory edits. I observed some huge chunks of microprofiler time spent from GetSetting/SetSetting calls. Presumably each one is making a disk read/write. This eliminates that class of issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I observed some huge chunks of microprofiler time spent from GetSetting/SetSetting calls. Presumably each one is making a disk read/write. And while not in this PR, a change in #290 introduces frequent read/writes that we need to accommodate
Solution
Plugin settings are now read from disk only once. In-memory edits are made from there.
Checklist
lune run testlocally before merging