Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a close button as a UX improvement #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

frazras
Copy link

@frazras frazras commented Sep 8, 2015

I created a close_button configuration and close button, all were done in js code.

@flouthoc
Copy link
Owner

@frazras it looks great 👍 but uglipop was supposed to be minimal , close button can be manually added by user as per their need , but you can add close button as uglipop plugin , i can create a uglipop plugin directory and you can add close button plugin there , so i'm creating a plugin directory you can add your js file there with description about thing your plugin does and a small text about author info , so i'll create directory plugins and you can make a pull like this plugins/closeButton/close.js you can add the exact same js file there , which will be uglipop+close button 😄

@flouthoc
Copy link
Owner

@frazras Would you like to take a look at conflict ? and re-create this PR

Copy link
Owner

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add these changes on updated js file to resolve conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants