Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: check python 3.11 #159

Merged
merged 5 commits into from
Nov 27, 2023
Merged

CI: check python 3.11 #159

merged 5 commits into from
Nov 27, 2023

Conversation

rgonzalezfluendo
Copy link
Contributor

The output of the make check with python 3.11 is different that with python 3.6

Adding a new test more with 3.11 to check with the max and min desp supported.

mdimopoulos
mdimopoulos approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@mdimopoulos mdimopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Although we would break master if we were to merge this without the recommended changes by black.
You'd need to check if the formatting suggestions in python 3.11 do not break the checks in 3.6.

@rgonzalezfluendo
Copy link
Contributor Author

error after d3d84c6:

Checking coding style with black... Run 'make format' to fix if needed
black --check fluster
would reformat /home/runner/work/fluster/fluster/fluster/decoders/__init__.py
would reformat /home/runner/work/fluster/fluster/fluster/decoders/dummy.py
would reformat /home/runner/work/fluster/fluster/fluster/decoders/av1_dav1d.py
would reformat /home/runner/work/fluster/fluster/fluster/decoders/chromium.py
would reformat /home/runner/work/fluster/fluster/fluster/decoders/h264_jct_vt.py
would reformat /home/runner/work/fluster/fluster/fluster/decoders/h265_jct_vt.py
would reformat /home/runner/work/fluster/fluster/fluster/decoders/cros_codecs.py
would reformat /home/runner/work/fluster/fluster/fluster/decoders/h266_vvdec.py
would reformat /home/runner/work/fluster/fluster/fluster/decoders/iso_mpeg4_aac.py
would reformat /home/runner/work/fluster/fluster/fluster/decoders/ffmpeg.py
would reformat /home/runner/work/fluster/fluster/fluster/decoders/gstreamer.py

Oh no! 💥 💔 💥
11 files would be reformatted, 11 files would be left unchanged.
make: *** [Makefile:57: format-check] Error 1
Error: Process completed with exit code 2.

@rgonzalezfluendo
Copy link
Contributor Author

error after fb978d8:

Checking coding style with black... Run 'make format' to fix if needed
black --check fluster
All done! ✨ 🍰 ✨
22 files would be left unchanged.
Checking with pylint... 
pylint --fail-under=10.0 fluster
************* Module fluster.decoder
fluster/decoder.py:18:0: E0611: No name 'ABC' in module 'abc' (no-name-in-module)
fluster/decoder.py:18:0: E0611: No name 'abstractmethod' in module 'abc' (no-name-in-module)
************* Module fluster.fluster
fluster/fluster.py:20:0: E0611: No name 'path' in module 'os' (no-name-in-module)
fluster/fluster.py:166:30: E1101: Module 'os' has no 'walk' member (no-member)
fluster/fluster.py:168:19: E1101: Module 'os' has no 'path' member (no-member)
fluster/fluster.py:171:28: E1101: Module 'os' has no 'path' member (no-member)
fluster/fluster.py:329:34: E1101: Module 'os' has no 'path' member (no-member)
************* Module fluster.test
fluster/test.py:67:26: E1101: Module 'os' has no 'path' member (no-member)
fluster/test.py:69:25: E1101: Module 'os' has no 'path' member (no-member)
fluster/test.py:110:16: E1101: Module 'os' has no 'path' member (no-member)
fluster/test.py:111:16: E1101: Module 'os' has no 'path' member (no-member)
fluster/test.py:113:12: E1101: Module 'os' has no 'remove' member (no-member)
************* Module fluster.utils
fluster/utils.py:36:20: E1101: Module 'os' has no 'path' member (no-member)
fluster/utils.py:148:11: E1101: Module 'os' has no 'environ' member (no-member)
fluster/utils.py:150:15: E1101: Module 'os' has no 'path' member (no-member)
fluster/utils.py:151:11: E1101: Module 'os' has no 'path' member (no-member)
fluster/utils.py:156:11: E1101: Module 'os' has no 'environ' member (no-member)
fluster/utils.py:159:22: E1101: Module 'os' has no 'pathsep' member (no-member)
fluster/utils.py:160:11: E1101: Module 'os' has no 'path' member (no-member)
fluster/utils.py:165:11: E1101: Module 'os' has no 'path' member (no-member)
fluster/utils.py:166:11: E1101: Module 'os' has no 'path' member (no-member)
************* Module fluster.main
fluster/main.py:52:31: E1101: Module 'os' has no 'path' member (no-member)
fluster/main.py:53:12: E1101: Module 'os' has no 'path' member (no-member)
fluster/main.py:55:29: E1101: Module 'os' has no 'path' member (no-member)
fluster/main.py:56:12: E1101: Module 'os' has no 'path' member (no-member)
fluster/main.py:58:26: E1101: Module 'os' has no 'path' member (no-member)
fluster/main.py:60:27: E1101: Module 'os' has no 'path' member (no-member)
fluster/main.py:61:12: E1101: Module 'os' has no 'path' member (no-member)
fluster/main.py:61:25: E1101: Module 'os' has no 'path' member (no-member)
fluster/main.py:70:24: E1101: Module 'os' has no 'path' member (no-member)
fluster/main.py:71:20: E1101: Module 'os' has no 'path' member (no-member)
fluster/main.py:88:8: E1101: Module 'os' has no 'environ' member (no-member)
fluster/main.py:88:49: E1101: Module 'os' has no 'path' member (no-member)
fluster/main.py:88:67: E1101: Module 'os' has no 'environ' member (no-member)
fluster/main.py:130:26: E1101: Module 'os' has no 'path' member (no-member)
fluster/main.py:131:15: E1101: Module 'os' has no 'path' member (no-member)
fluster/main.py:132:30: E1101: Module 'os' has no 'path' member (no-member)
fluster/main.py:134:24: E1101: Module 'os' has no 'path' member (no-member)
************* Module fluster.test_suite
fluster/test_suite.py:19:0: E0611: No name 'path' in module 'os' (no-name-in-module)
fluster/test_suite.py:171:19: E1101: Module 'os' has no 'path' member (no-member)
fluster/test_suite.py:172:20: E1101: Module 'os' has no 'path' member (no-member)
fluster/test_suite.py:172:43: E1101: Module 'os' has no 'path' member (no-member)
fluster/test_suite.py:173:15: E1101: Module 'os' has no 'path' member (no-member)
fluster/test_suite.py:174:12: E1101: Module 'os' has no 'makedirs' member (no-member)
fluster/test_suite.py:177:16: E1101: Module 'os' has no 'path' member (no-member)
fluster/test_suite.py:184:16: E1101: Module 'os' has no 'remove' member (no-member)
fluster/test_suite.py:224:16: E1101: Module 'os' has no 'remove' member (no-member)
fluster/test_suite.py:236:15: E1101: Module 'os' has no 'path' member (no-member)
fluster/test_suite.py:237:12: E1101: Module 'os' has no 'makedirs' member (no-member)
fluster/test_suite.py:408:25: E1101: Module 'os' has no 'path' member (no-member)
fluster/test_suite.py:409:11: E1101: Module 'os' has no 'path' member (no-member)
fluster/test_suite.py:411:8: E1101: Module 'os' has no 'makedirs' member (no-member)
fluster/test_suite.py:437:34: E1101: Module 'os' has no 'path' member (no-member)
************* Module fluster.decoders
fluster/decoders/__init__.py:19:0: E0611: No name 'path' in module 'os' (no-name-in-module)
fluster/decoders/__init__.py:21:20: E1101: Module 'os' has no 'path' member (no-member)
fluster/decoders/__init__.py:21:33: E1101: Module 'os' has no 'path' member (no-member)
fluster/decoders/__init__.py:23:4: E1101: Module 'os' has no 'path' member (no-member)
fluster/decoders/__init__.py:23:21: E1101: Module 'os' has no 'path' member (no-member)
fluster/decoders/__init__.py:25:7: E1101: Module 'os' has no 'path' member (no-member)

-----------------------------------
Your code has been rated at 8.21/10

make: *** [Makefile:62: lint] Error 2
Error: Process completed with exit code 2.

mdimopoulos
mdimopoulos reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@mdimopoulos mdimopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pylint backwards compatibility with 3.6 not broken?

.pylintrc Outdated Show resolved Hide resolved
@mdimopoulos mdimopoulos self-requested a review November 27, 2023 16:25
mdimopoulos
mdimopoulos reviewed Nov 27, 2023
View reviewed changes
Copy link
Contributor

@mdimopoulos mdimopoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check previous comment

@rgonzalezfluendo
Copy link
Contributor Author

Warning after 8e14cd4

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-python@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

@rubenrua @rgonzalezfluendo
CI: check python 3.11
99633db 
The output of the make check with python 3.11 is different that with
python 3.6

Adding a new test more with 3.11 to check with the max and min desp
supported.
@rubenrua @rgonzalezfluendo
black: format all python files
8dc5623
@rubenrua @rgonzalezfluendo
Update pylint dep
4578426
@rubenrua @rgonzalezfluendo
CI: Update checkout and setup-python GitHub actions
b38500d 
Fixed:

> The following actions uses node12 which is deprecated and
> will be forced to run on node16: actions/checkout@v2,
> actions/setup-python@v2. For more info: [1]

[1] https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
@rubenrua @rgonzalezfluendo
fixup! Update pylint dep
942a175
@rgonzalezfluendo rgonzalezfluendo merged commit 9c70053 into master Nov 27, 2023
3 checks passed
@rgonzalezfluendo rgonzalezfluendo deleted the ci_arch branch November 27, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdimopoulos mdimopoulos mdimopoulos approved these changes

@ylatuya ylatuya Awaiting requested review from ylatuya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rgonzalezfluendo @mdimopoulos @rubenrua