-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COM-6142 #187
COM-6142 #187
Conversation
mcesariniflu
commented
Aug 5, 2024
The foundations seem solid to me. I have several change requests though to make the code neater. See individual comments Important time stats
So in a future iteration we should try to bring the download logic of fluster close to the one used in the test suite generator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All pending points have been addressed 👍🏼.
I encountered issues running gen_av1_argon.py
successfully on MacOS. I decided to push a fixup commit that solves any problems.
@mcesariniflu let me know if the latest version of the script runs well on Ubuntu.
- created new test suite generator script - modified test suite structure to accomodate this special case - added the generated test suite - tested to work on Ubuntu 20, 22 and MacOS 14.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that it works fine on Ubuntu 20. Approved