OCP-5946 Fix H266 output format #198
Conversation
We'll add support for GRAY10_LE16 soon, so we'll need to distinguish between both GRAY10_LE16 and GRAY10_LE32.
The proper output format of the decoder is 16b aligned, instead of 32.
|
can you change the status from draft? |
| @@ -51,7 +51,8 @@ class OutputFormat(Enum): | |||
| GBRP12LE = "gbrp12le" | |||
| GBRP14LE = "gbrp14le" | |||
| GRAY = "gray" | |||
| GRAY10LE = "gray10le" | |||
| GRAY10LE16 = "gray10le16" | |||
| GRAY10LE32 = "gray10le32" | |||
There was a problem hiding this comment.
I don't think introducing GRAY10LE32 make any sense here. Please drop.
fyi, this is 3 pixels per 32bit packing, with 2 bit padding, we should nto do conformance on that.
There was a problem hiding this comment.
I also think we should keep gray10le to match with ffmpeg name, and is 16bit per pixels.
| @@ -60,7 +60,8 @@ def output_format_to_gst(output_format: OutputFormat) -> str: | |||
| """Return GStreamer pixel format""" | |||
| mapping = { | |||
| OutputFormat.GRAY: "GRAY8", | |||
| OutputFormat.GRAY10LE: "GRAY10_LE32", | |||
| OutputFormat.GRAY10LE16: "GRAY10_LE16", | |||
| OutputFormat.GRAY10LE32: "GRAY10_LE32", | |||
There was a problem hiding this comment.
GRAY10LE16 does not exist in GStreamer, please submit upstream so we have matching names. Should be a single plane variant of GST_VIDEO_FORMAT_I420_10LE. It is incompatible with GRAY16_LE because GRAY10LE padding is on the opposite side.
|
I'm pretty sure this breaks FFMPEG, and cannot work in GStreamer yet, since the format has not been introduce. Support in videocodectestsink is needed too, we should allow I420_10LE to GRAY_10LE conversion too, since many decoder produce I420 even if the codec holds monochrome. |
Fix H266 TS output format gray10le32->gray10le16
The proper output format of the decoder is 16b aligned, instead of 32.