COM-12575: Investigate erratic behaviour of AAC audio reference decoders #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rsanchez87
commented
Nov 19, 2024
rsanchez87
commented
- Include improvements in mpeg reference decoders building
- Add JSON generation from ISO-MPEG2-AAC decoder in "iso_mpeg2_aac.py" file
- Change ""result":" values of MPEG2_AAC-ADIF.json and MPEG2_AAC-ADTS.json, from reference decoder, .pcm files
* Include improvements in mpeg reference decoders building * Add JSON generation from ISO-MPEG2-AAC decoder in "iso_mpeg2_aac.py" file * Change ""result":" values of MPEG2_AAC-ADIF.json and MPEG2_AAC-ADTS.json, from reference decoder, .pcm files
* Pass to x32 mpeg2 and mpeg4 building * improve "ifeq" to install all dependencies (gcc-multilib and g++-multilib)
* use glob library, (review comment #209 (comment))
mdimopoulos
approved these changes
Nov 19, 2024
* glob.glob only return existing files. os.path.exists is not needed.
rgonzalezfluendo
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.