Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg: Detect and fail on software decoder fallback #224

Merged

Conversation

ndufresne
Copy link
Contributor

@ndufresne ndufresne commented Dec 17, 2024

The goal of fluster is to test one specific implementation, allowing software fallback hides possible integration issues.

@rgonzalezfluendo
Copy link
Contributor

Ohh, Thanks you!

offtopic: In my non-priority TODO list for FFMpeg I had implementing --no-fallback.

Copy link
Contributor

@rgonzalezfluendo rgonzalezfluendo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, make format is missing.

pre-commit install to avoid this in the future.

@ndufresne ndufresne force-pushed the ffmpeg-detect-sw-fallback branch from 983e930 to 32b661f Compare December 17, 2024 19:31
@ndufresne
Copy link
Contributor Author

ndufresne commented Dec 17, 2024

Figured-out there was a script to install the hooks now, this will save time indeed.

@ndufresne ndufresne force-pushed the ffmpeg-detect-sw-fallback branch from 32b661f to 069a0a8 Compare December 17, 2024 19:34
@ndufresne
Copy link
Contributor Author

In short, this change will kind of regress of lot of ffmpeg test, but from there we get the score for the selected HW accelerator, not a mix of that and the software decoder.

@ndufresne
Copy link
Contributor Author

Let me improve the commit message now.

The goal of fluster is to test one specific implementation, allowing
software fallback hides possible integration issues.
@ndufresne ndufresne force-pushed the ffmpeg-detect-sw-fallback branch from 069a0a8 to 488c852 Compare December 17, 2024 20:28
@rgonzalezfluendo rgonzalezfluendo merged commit 0085a9a into fluendo:master Dec 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants