Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COM-12616 #225

Merged
merged 2 commits into from
Dec 24, 2024
Merged

COM-12616 #225

merged 2 commits into from
Dec 24, 2024

Conversation

mcesariniflu
Copy link
Contributor

@mcesariniflu mcesariniflu commented Dec 18, 2024

AAC:

  • The ISO_IEC_14496-26_2010 name was changed by MPEG4_AAC-ADTS

H264:

  • The JVT-Professional_profiles_V1 name was changed by JVT-Professional_profiles

  • The JVT-SVC_V1 name was changed by JVT-SVC

    modified: README.md
    modified: pyproject.toml
    modified: scripts/gen_jvt.py
    renamed: test_suites/aac/ISO_IEC_14496-26_2010.json -> test_suites/aac/MPEG4_AAC-ADTS.json
    renamed: test_suites/h264/JVT-Professional_profiles_V1.json -> test_suites/h264/JVT-Professional_profiles.json
    renamed: test_suites/h264/JVT-SVC_V1.json -> test_suites/h264/JVT-SVC.json

AAC:
- The ISO_IEC_14496-26_2010 name was changed by MPEG4_AAC-ADTS
H264:
- The JVT-Professional_profiles_V1 name was changed by JVT-Professional_profiles
- The JVT-SVC_V1 name was changed by JVT-SVC
	modified:   README.md
	modified:   pyproject.toml
	modified:   scripts/gen_jvt.py
	renamed:    test_suites/aac/ISO_IEC_14496-26_2010.json -> test_suites/aac/MPEG4_AAC-ADTS.json
	renamed:    test_suites/h264/JVT-Professional_profiles_V1.json -> test_suites/h264/JVT-Professional_profiles.json
	renamed:    test_suites/h264/JVT-SVC_V1.json -> test_suites/h264/JVT-SVC.json
@rsanchez87 rsanchez87 self-requested a review December 19, 2024 12:41
Copy link
Contributor

@rsanchez87 rsanchez87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A PR should be created in flu-plugins to change the names too... it's very important:

image

README.md Outdated Show resolved Hide resolved
ISO_IEC_13818-4_2004 updated by MPEG2 AAC ADTS
- modified:   README.md
@rsanchez87 rsanchez87 self-requested a review December 20, 2024 09:54
Copy link
Contributor

@rsanchez87 rsanchez87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Wait at flu-plugins changes before merge https://github.com/fluendo/flu-plugins/pull/677

@mcesariniflu mcesariniflu merged commit f18d6fb into master Dec 24, 2024
3 checks passed
@mcesariniflu mcesariniflu deleted the COM-12616 branch December 24, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants