Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOJIRA: Improve uniqueness of file naming for client coverage reports #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danailbd
Copy link

It's a pretty rare case but we've experienced some inconsistencies in gpii-app renderer processes coverage which makes use of the gpii.testem.coverage.express (coverageServer.js).

These are some changes of a collision of random numbers which are currently used for uniqueness of filenames. We could use a timestamp instead which should better ensure uniqueness.

There are some odds that there might be a collision of random numbers.
Using timestamp instead should ensure uniqueness of the coverage file names.
@gpii-bot
Copy link

Could one of the admins verify that these changes are reasonable to test? If so, please reply with "ok to test".

@jobara jobara changed the base branch from master to main October 22, 2020 13:43
@the-t-in-rtf
Copy link
Collaborator

Apologies for the extreme delay in looking at this. I think the changes are fine, but would like to see it run in CI. Can you merge with upstream main to pick up the CI configuration?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants