Drag Select Special Option for Asset Picker #658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… didn't have much luck this way
AlexV525
requested changes
Nov 10, 2024
| @@ -30,6 +30,7 @@ dependencies: | |||
| provider: ^6.0.5 | |||
| video_player: ^2.7.0 | |||
| visibility_detector: ^0.4.0 | |||
| drag_select_grid_view: ^0.6.2 | |||
There was a problem hiding this comment.
Introducing such a package will significantly increase the risk to our functionality since we don't understand how it works and cannot control if it can serve us well.
There was a problem hiding this comment.
Thank you for the feedback. Yes, I think you are probably right. Introducing a new package brings uncertainties. And from my time working on this, making this package and drag_select_grid_view work together nicely was difficult, it would have been easier to create it from scratch. I tested #660, it appears to work. Seems like a good solution.
|
I'm closing this based on the above discussion. Willing to hear your feedback with #660. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In these commits there is a new drag and select feature that is available as a special option, just as no-preview is one of these options. There is also auto scroll when the user moves their finger/stylus too close to the bottom or top, it scrolls for them so they can keep selecting as it scrolls. It takes advantage of the drag_select_grid_view library.
The demo in this repo is also updated to have a drag select example.
I think drag and select is a very useful feature to have, so users can select a large number of items in a short time, and don't have to bother to select each item on an individual basis.
Please pardon my Chinese. I know it probably isn't perfect.
This is already done in a different pull request, well done to them: #465. They did it in much less lines of code. Maybe ours could be combined somehow.
I am happy to change anything that needs to be changed.