Skip to content

Commit

Permalink
Merge pull request #1552 from fluxcd/canary-dep-finalize
Browse files Browse the repository at this point in the history
controller: wait for canary deployment to be ready before removing finalizers
  • Loading branch information
aryan9600 authored Nov 20, 2023
2 parents 8c078e8 + 63ec848 commit 749e099
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/controller/finalizer.go
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,10 @@ func (c *Controller) finalize(old interface{}) error {
// Ensure that targetRef has met a ready state
c.logger.Infof("Checking if canary is ready %s.%s", canary.Name, canary.Namespace)
backoff := wait.Backoff{
Duration: time.Second,
Duration: time.Second * 3,
Factor: 2,
Cap: canary.GetAnalysisInterval(),
Steps: 4,
}
retry.OnError(backoff, func(err error) bool {
return err.Error() == "retriable error"
Expand Down

0 comments on commit 749e099

Please sign in to comment.