set original node selector value when finalizing service #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rye-sw
force-pushed
the
fix-issue-1534
branch
from
fb6982d to
6e0b5b8
Compare
Signed-off-by: rye-sw <[email protected]>
rye-sw
force-pushed
the
fix-issue-1534
branch
from
6e0b5b8 to
d796c20
Compare
of course :) |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1537 +/- ##
=======================================
Coverage 55.04% 55.04%
=======================================
Files 85 85
Lines 10354 10354
=======================================
Hits 5699 5699
Misses 3993 3993
Partials 662 662
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As issue #1534 reported, the reverted service does not have the same selector as the original one, as a result the reverted service has not endpoints.
KubernetesDefaultRouter has the original selector label and selector value, we should use that instead of canary.Spec.TargetRef.Name
Signed-off-by: rye-sw [email protected]