-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra tags to Grafana annotations #405
base: main
Are you sure you want to change the base?
Conversation
This adds the name and namespace tags to Grafana annotations. This makes it possible to use this provider when one has multiple Flux tenants writing to the same Grafana instance. Signed-off-by: Bill Franklin <[email protected]>
I can also add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document this change in https://github.com/fluxcd/notification-controller/blob/main/docs/spec/v1beta1/provider.md#grafana
@bilbof if you need assistance in documenting this change, I'd be happy to help getting this PR merged. Just let me know. |
Hey guys, any updates on this PR? I'd like to see this one get merged. Regarding the documentation: This PR is only adding additional tags. The current tags are not documented anywhere |
@stefanprodan sorry to ping you, but the PR is not moving forward, though it's an easy fix... How can we help to get this PR merged? |
Any chance this got merged? |
This PR is abandoned, but since this was opened, things have evolved. You can add metadata in the Alert that will end up as Grafana annotations, for example: apiVersion: notification.toolkit.fluxcd.io/v1beta3
kind: Alert
metadata:
name: <name>
spec:
eventMetadata:
tenant: "team1"
env: "production"
region: "us-east-1" |
Thanks @stefanprodan for responding. |
@cmitri-harris feel free to open a new PR for this, we can close this one and review yours. |
This adds the name and namespace tags to Grafana annotations.
This makes it possible to use the Grafana provider when one has multiple Flux tenants writing to the same Grafana instance.