This repository has been archived by the owner on Jun 17, 2024. It is now read-only.
Fix bash condition in endtoend script #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haytham Abuelfutuh <[email protected]>
kumare3
reviewed
Nov 12, 2021
| then | ||
| sed -i.bak -e "s_${IMAGE_NAME}:.*_${IMAGE}_g" ${OUT}/kustomize/base/propeller/deployment.yaml | ||
| sed -i.bak -e "s_${IMAGE_NAME}:.*_${IMAGE}_g" "${OUT}"/kustomize/base/propeller/deployment.yaml |
There was a problem hiding this comment.
Ideally not... might as well change it now I guess...
There was a problem hiding this comment.
I'll leave that for another PR 😬 ... I want to get this in for 18.1
kumare3
reviewed
Nov 12, 2021
boilerplate/flyte/end2end/end2end.sh
Outdated
| fi | ||
|
|
||
| if [ ${IMAGE} -eq "flyteadmin" ] | ||
| if [ "${IMAGE}" == "flyteadmin" ] |
Signed-off-by: Haytham Abuelfutuh <[email protected]>
wild-endeavor
approved these changes
Nov 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Haytham Abuelfutuh [email protected]
fixes: flyteorg/flyte#1825
tested here: flyteorg/flytepropeller#363