upstream ArrayNode DataMode + BindingData LiteralOffloadedMetadata idl changes #6074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Dittamo <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6074 +/- ##
==========================================
- Coverage 36.98% 36.98% -0.01%
==========================================
Files 1318 1318
Lines 132449 132475 +26
==========================================
+ Hits 48989 48991 +2
- Misses 79207 79231 +24
Partials 4253 4253
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@pvditt , what else is missing here? |
Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Paul Dittamo <[email protected]>
Signed-off-by: Paul Dittamo <[email protected]>
pvditt
changed the title
|
Was just waiting for the PR to get merged on our end. Will open source it, but will do that in a follow up as there's been a bit of divergence on our private fork for ArrayNode. |
3 tasks
eapolinario
approved these changes
Dec 19, 2024
eapolinario
pushed a commit
that referenced
this pull request
Dec 20, 2024
…l changes (#6074) * upstream DataMode Signed-off-by: Paul Dittamo <[email protected]> * update descriptions Signed-off-by: Paul Dittamo <[email protected]> * upstream binding data idl update Signed-off-by: Paul Dittamo <[email protected]> --------- Signed-off-by: Paul Dittamo <[email protected]>
eapolinario
added a commit
that referenced
this pull request
Dec 20, 2024
…l changes (#6074) (#6121) * upstream DataMode * update descriptions * upstream binding data idl update --------- Signed-off-by: Paul Dittamo <[email protected]> Co-authored-by: Paul Dittamo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#3573
Why are the changes needed?
Adding support for mapping over reference tasks. Will open source the changes in a follow up PR
What changes were proposed in this pull request?
Updating IDL for ArrayNode + BindingData to support mapping over reference tasks (will all be upstreamed to OSS)
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link