Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some function names in comment #6122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: fix some function names in comment #6122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions flyteplugins/go/tasks/pluginmachinery/k8s/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,12 +148,12 @@ type UpdateResourceOperation struct {
Options []client.UpdateOption
}

// AbortBehavior that patches the default resource
// AbortBehaviorPatchDefaultResource that patches the default resource
func AbortBehaviorPatchDefaultResource(patchOperation PatchResourceOperation, deleteOnErr bool) AbortBehavior {
return AbortBehaviorPatch(patchOperation, deleteOnErr, nil)
}

// AbortBehavior that patches the specified resource
// AbortBehaviorPatch that patches the specified resource
func AbortBehaviorPatch(patchOperation PatchResourceOperation, deleteOnErr bool, resource client.Object) AbortBehavior {
return AbortBehavior{
Resource: resource,
Expand All @@ -162,12 +162,12 @@ func AbortBehaviorPatch(patchOperation PatchResourceOperation, deleteOnErr bool,
}
}

// AbortBehavior that updates the default resource
// AbortBehaviorUpdateDefaultResource that updates the default resource
func AbortBehaviorUpdateDefaultResource(updateOperation UpdateResourceOperation, deleteOnErr bool) AbortBehavior {
return AbortBehaviorUpdate(updateOperation, deleteOnErr, nil)
}

// AbortBehavior that updates the specified resource
// AbortBehaviorUpdate that updates the specified resource
func AbortBehaviorUpdate(updateOperation UpdateResourceOperation, deleteOnErr bool, resource client.Object) AbortBehavior {
return AbortBehavior{
Resource: resource,
Expand All @@ -176,12 +176,12 @@ func AbortBehaviorUpdate(updateOperation UpdateResourceOperation, deleteOnErr bo
}
}

// AbortBehavior that deletes the default resource
// AbortBehaviorDeleteDefaultResource that deletes the default resource
func AbortBehaviorDeleteDefaultResource() AbortBehavior {
return AbortBehaviorDelete(nil)
}

// AbortBehavior that deletes the specified resource
// AbortBehaviorDelete that deletes the specified resource
func AbortBehaviorDelete(resource client.Object) AbortBehavior {
return AbortBehavior{
Resource: resource,
Expand Down