Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport changes for 14.1 #3006

Merged
merged 5 commits into from
Dec 16, 2024

Conversation

wild-endeavor
Copy link
Contributor

taieeuu and others added 5 commits December 16, 2024 10:33
* fix: dbt-test

Signed-off-by: taieeuu <[email protected]>

* fix: run lint on codebase

Signed-off-by: taieeuu <[email protected]>

---------

Signed-off-by: taieeuu <[email protected]>
* Add a test

Signed-off-by: Thomas Newton <[email protected]>

* Fix

Signed-off-by: Thomas Newton <[email protected]>

* Also test workflows

Signed-off-by: Thomas Newton <[email protected]>

* Fix missing import

Signed-off-by: Thomas Newton <[email protected]>

* Fix via make unit_test

Signed-off-by: Thomas Newton <[email protected]>

* Autoformat

Signed-off-by: Thomas Newton <[email protected]>

---------

Signed-off-by: Thomas Newton <[email protected]>
Signed-off-by: Samhita Alla <[email protected]>
Signed-off-by: Eduardo Apolinario <[email protected]>
Co-authored-by: Eduardo Apolinario <[email protected]>
@wild-endeavor wild-endeavor changed the title Rel v1.14 bp 2989 2992 2997 2998 3001 Backport changes for 14.1 Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 47.61905% with 11 lines in your changes missing coverage. Please review.

Project coverage is 51.55%. Comparing base (0b4a60a) to head (ccbb6f5).
Report is 2 commits behind head on release-v1.14.

Files with missing lines Patch % Lines
flytekit/core/data_persistence.py 0.00% 11 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (0b4a60a) and HEAD (ccbb6f5). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (0b4a60a) HEAD (ccbb6f5)
5 4
Additional details and impacted files
@@                Coverage Diff                 @@
##           release-v1.14    #3006       +/-   ##
==================================================
- Coverage          81.40%   51.55%   -29.85%     
==================================================
  Files                200      203        +3     
  Lines              21012    21194      +182     
  Branches            2707     2704        -3     
==================================================
- Hits               17104    10926     -6178     
- Misses              3151     9677     +6526     
+ Partials             757      591      -166     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wild-endeavor wild-endeavor merged commit 7eedc68 into release-v1.14 Dec 16, 2024
103 of 105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants