Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warns and errors #272

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Warns and errors #272

wants to merge 10 commits into from

Conversation

alhom
Copy link
Contributor

@alhom alhom commented Sep 2, 2024

Going through logging.info calls etc. to have actual errors and warnings raised instead of printing "ERROR" to log and causing problems in downstream.

Plan:
logging.info("WARNING something suspicious") -> warnings.warn("something suspicious") or logging.warn("something suspicious") if the warning bears repeating
logging.info("ERROR a bad thing") -> raise ADescriptiveException("a bad thing")
if a != b: logging.info("This is weird, check pls") -> assert a == b

Going through the files changed in #269, since that's a handy list. Going through file-by-file.

@alhom
Copy link
Contributor Author

alhom commented Sep 2, 2024

@vetarvus, would you agree with the changes to non_maxwellianity? If there is no B available for some cell, I don't think there will be for other cells either, and then it's no use to continue calculation with a bi-maxwellian anyway, no?

@vetarvus
Copy link
Contributor

vetarvus commented Sep 2, 2024

Non-Maxwellianity looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants