Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going through
logging.info
calls etc. to have actual errors and warnings raised instead of printing "ERROR" to log and causing problems in downstream.Plan:
logging.info("WARNING something suspicious")
->warnings.warn("something suspicious")
orlogging.warn("something suspicious")
if the warning bears repeatinglogging.info("ERROR a bad thing")
->raise ADescriptiveException("a bad thing")
if a != b: logging.info("This is weird, check pls")
->assert a == b
Going through the files changed in #269, since that's a handy list. Going through file-by-file.