Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fsgrid testing and restructuring #1062

Open
wants to merge 29 commits into
base: dev
Choose a base branch
from
Open

Conversation

cscjlan
Copy link

@cscjlan cscjlan commented Nov 12, 2024

This updates vlasiator to use the updated FsGrid. Most changes are due to:

  • automatic code formatting by clang-format
  • FsGrid member variables becoming private: accessing them through a function (mostly DX, DY, DZ)
  • FsGrid member variables becoming const: returned variables must be const ref instead of ref
  • FsGrid construction happens in one go, not in three steps: added some input parameters
  • FsGrid is not copyable anymore: filterMoments copies and updates the data of a grid object instead of the object itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant