-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error handling on failed writes #904
base: dev
Are you sure you want to change the base?
Conversation
Next time, call it "retrigger CI" or something, or just "CI", instead of "dummy". :) |
So from our f2f2z discussion:
|
Addressed points from the discussion, but untested for now |
Right so now I agree with the logic of the checks around the file removal. Let's see about testing as just discussed. |
So for the test status on this -- the success path is checked by CI. Failure path is a bit tougher, since Vlasiator is too smart to try to write to paths without access. I did try hardcoding to |
Have you verified that the string containing the restart file name is correct, even in case of a successful write? |
Requires fmihpc/vlsv#56 so failed writes actually return errors. Addresses #903.