Fix Bavaria #269

Signed-off-by: XSpielinbox <[email protected]>
focus-shift · Dec 3, 2024 · 4c4498c · 4c4498c
1 parent 0d0f6ca
commit 4c4498c
Show file tree

Hide file tree

Showing 11 changed files with 9 additions and 116 deletions.
diff --git a/jollyday-core/src/main/resources/descriptions/country_descriptions.properties b/jollyday-core/src/main/resources/descriptions/country_descriptions.properties
@@ -167,10 +167,6 @@ country.description.de.be     = Berlin
 country.description.de.bw     = Baden-Württemberg
 country.description.de.by     = Bavaria
 country.description.de.by.ag  = Augsburg
-country.description.de.by.in  = Ingolstadt
-country.description.de.by.mu  = Munich
-country.description.de.by.re  = Regensburg
-country.description.de.by.wu  = Würzburg
 country.description.de.hb     = Bremen
 country.description.de.he     = Hesse
 country.description.de.hh     = Hamburg

diff --git a/jollyday-core/src/main/resources/descriptions/country_descriptions_de.properties b/jollyday-core/src/main/resources/descriptions/country_descriptions_de.properties
@@ -167,10 +167,6 @@ country.description.de.be     = Berlin
 country.description.de.bw     = Baden-Württemberg
 country.description.de.by     = Bayern
 country.description.de.by.ag  = Augsburg
-country.description.de.by.in  = Ingolstadt
-country.description.de.by.mu  = München
-country.description.de.by.re  = Regensburg
-country.description.de.by.wu  = Würzburg
 country.description.de.hb     = Bremen
 country.description.de.he     = Hessen
 country.description.de.hh     = Hamburg

diff --git a/jollyday-core/src/main/resources/descriptions/country_descriptions_el.properties b/jollyday-core/src/main/resources/descriptions/country_descriptions_el.properties
@@ -167,10 +167,6 @@ country.description.de.be     = Βερολίνο
 country.description.de.bw     = Μπάντεν-Βίρτεμπεργκ
 country.description.de.by     = Βαυαρία
 country.description.de.by.ag  = Άουγκσμπουργκ
-country.description.de.by.in  = Ίνγκολστατ
-country.description.de.by.mu  = Μόναχο
-country.description.de.by.re  = Ρέγκενσμπουργκ
-country.description.de.by.wu  = Βίρτσμπουργκ
 country.description.de.hb     = Βρέμη
 country.description.de.he     = Έσση
 country.description.de.hh     = Αμβούργο

diff --git a/jollyday-core/src/main/resources/descriptions/country_descriptions_fr.properties b/jollyday-core/src/main/resources/descriptions/country_descriptions_fr.properties
@@ -167,10 +167,6 @@ country.description.de.be     = Berlin
 country.description.de.bw     = Bade-Wurtemberg
 country.description.de.by     = Bavière
 country.description.de.by.ag  = Augsburg
-country.description.de.by.in  = Ingolstadt
-country.description.de.by.mu  = Munich
-country.description.de.by.re  = Regensburg
-country.description.de.by.wu  = Würzburg
 country.description.de.hb     = Brême
 country.description.de.he     = Hesse
 country.description.de.hh     = Hambourg

diff --git a/jollyday-core/src/main/resources/descriptions/country_descriptions_nl.properties b/jollyday-core/src/main/resources/descriptions/country_descriptions_nl.properties
@@ -167,10 +167,6 @@ country.description.de.be     = Berlin
 country.description.de.bw     = Baden-Württemberg
 country.description.de.by     = Bavaria
 country.description.de.by.ag  = Augsburg
-country.description.de.by.in  = Ingolstadt
-country.description.de.by.mu  = Munich
-country.description.de.by.re  = Regensburg
-country.description.de.by.wu  = Würzburg
 country.description.de.hb     = Bremen
 country.description.de.he     = Hesse
 country.description.de.hh     = Hamburg

diff --git a/jollyday-core/src/main/resources/descriptions/country_descriptions_pt.properties b/jollyday-core/src/main/resources/descriptions/country_descriptions_pt.properties
@@ -167,10 +167,6 @@ country.description.de.be     = Berlin
 country.description.de.bw     = Baden-Wörtemberg
 country.description.de.by     = Bavária
 country.description.de.by.ag  = Augsburg
-country.description.de.by.in  = Ingolstadt
-country.description.de.by.mu  = Munich
-country.description.de.by.re  = Regensburg
-country.description.de.by.wu  = Würzburg
 country.description.de.hb     = Bremen
 country.description.de.he     = Hesse
 country.description.de.hh     = Hamburgo

diff --git a/jollyday-core/src/main/resources/descriptions/country_descriptions_sv.properties b/jollyday-core/src/main/resources/descriptions/country_descriptions_sv.properties
@@ -167,10 +167,6 @@ country.description.de.be     = Berlin
 country.description.de.bw     = Baden-Württemberg
 country.description.de.by     = Bavaria
 country.description.de.by.ag  = Augsburg
-country.description.de.by.in  = Ingolstadt
-country.description.de.by.mu  = Munich
-country.description.de.by.re  = Regensburg
-country.description.de.by.wu  = Würzburg
 country.description.de.hb     = Bremen
 country.description.de.he     = Hesse
 country.description.de.hh     = Hamburg

diff --git a/jollyday-core/src/main/resources/holidays/Holidays_de.xml b/jollyday-core/src/main/resources/holidays/Holidays_de.xml
@@ -32,6 +32,7 @@
 
   <Sources>
     <Source>https://en.wikipedia.org/wiki/Public_holidays_in_Germany</Source>
+    <Source of="ISO 3166">https://www.iso.org/obp/ui/#iso:code:3166:DE</Source>
     <Source of="ISO 3166-2">https://en.wikipedia.org/wiki/ISO_3166-2:DE</Source>
   </Sources>
 
@@ -74,6 +75,11 @@
   <SubConfigurations hierarchy="by" description="Bavaria">
     <Holidays>
       <Fixed month="JANUARY" day="6" descriptionPropertiesKey="EPIPHANY"/>
+
+      <!-- it actually is not in all of Bavaria, but in most of it:
+      https://www.statistik.bayern.de/statistik/gebiet_bevoelkerung/zensus/himmelfahrt/index.php -->
+      <Fixed day="15" month="AUGUST" descriptionPropertiesKey="ASSUMPTION_DAY"/>
+
       <Fixed month="NOVEMBER" day="1" descriptionPropertiesKey="ALL_SAINTS"/>
       <RelativeToFixed validFrom="1981" validTo="1989" descriptionPropertiesKey="REPENTANCE_PRAYER">
         <Weekday>WEDNESDAY</Weekday>
@@ -83,34 +89,9 @@
       <ChristianHoliday type="CORPUS_CHRISTI" descriptionPropertiesKey="christian.CORPUS_CHRISTI"/>
     </Holidays>
 
-    <SubConfigurations hierarchy="mu" description="Munich">
-      <Holidays>
-        <Fixed day="15" month="AUGUST" descriptionPropertiesKey="ASSUMPTION_DAY"/>
-      </Holidays>
-    </SubConfigurations>
-
     <SubConfigurations hierarchy="ag" description="Augsburg">
       <Holidays>
         <Fixed day="8" month="AUGUST" descriptionPropertiesKey="PEACE"/>
-        <Fixed day="15" month="AUGUST" descriptionPropertiesKey="ASSUMPTION_DAY"/>
-      </Holidays>
-    </SubConfigurations>
-
-    <SubConfigurations hierarchy="wu" description="Würzburg">
-      <Holidays>
-        <Fixed day="15" month="AUGUST" descriptionPropertiesKey="ASSUMPTION_DAY"/>
-      </Holidays>
-    </SubConfigurations>
-
-    <SubConfigurations hierarchy="re" description="Regensburg">
-      <Holidays>
-        <Fixed day="15" month="AUGUST" descriptionPropertiesKey="ASSUMPTION_DAY"/>
-      </Holidays>
-    </SubConfigurations>
-
-    <SubConfigurations hierarchy="in" description="Ingolstadt">
-      <Holidays>
-        <Fixed day="15" month="AUGUST" descriptionPropertiesKey="ASSUMPTION_DAY"/>
       </Holidays>
     </SubConfigurations>
   </SubConfigurations>

diff --git a/jollyday-tests/src/test/resources/holidays/Holidays_test_de_2010.xml b/jollyday-tests/src/test/resources/holidays/Holidays_test_de_2010.xml
@@ -36,32 +36,12 @@
     <Holidays>
       <Fixed month="JANUARY" day="6" descriptionPropertiesKey="EPIPHANY"/>
       <Fixed month="JUNE" day="3" descriptionPropertiesKey="christian.CORPUS_CHRISTI"/>
+      <Fixed month="AUGUST" day="15" descriptionPropertiesKey="ASSUMPTION_DAY"/>
       <Fixed month="NOVEMBER" day="1" descriptionPropertiesKey="ALL_SAINTS"/>
     </Holidays>
-    <SubConfigurations hierarchy="mu" description="München">
-      <Holidays>
-        <Fixed month="AUGUST" day="15" descriptionPropertiesKey="ASSUMPTION_DAY"/>
-      </Holidays>
-    </SubConfigurations>
     <SubConfigurations hierarchy="ag" description="Augsburg">
       <Holidays>
         <Fixed month="AUGUST" day="8" descriptionPropertiesKey="PEACE"/>
-        <Fixed month="AUGUST" day="15" descriptionPropertiesKey="ASSUMPTION_DAY"/>
-      </Holidays>
-    </SubConfigurations>
-    <SubConfigurations hierarchy="wu" description="Würzburg">
-      <Holidays>
-        <Fixed month="AUGUST" day="15" descriptionPropertiesKey="ASSUMPTION_DAY"/>
-      </Holidays>
-    </SubConfigurations>
-    <SubConfigurations hierarchy="re" description="Regensburg">
-      <Holidays>
-        <Fixed month="AUGUST" day="15" descriptionPropertiesKey="ASSUMPTION_DAY"/>
-      </Holidays>
-    </SubConfigurations>
-    <SubConfigurations hierarchy="in" description="Ingolstadt">
-      <Holidays>
-        <Fixed month="AUGUST" day="15" descriptionPropertiesKey="ASSUMPTION_DAY"/>
       </Holidays>
     </SubConfigurations>
   </SubConfigurations>

diff --git a/jollyday-tests/src/test/resources/holidays/Holidays_test_de_2022.xml b/jollyday-tests/src/test/resources/holidays/Holidays_test_de_2022.xml
@@ -37,32 +37,12 @@
     <Holidays>
       <Fixed month="JANUARY" day="6" descriptionPropertiesKey="EPIPHANY"/>
       <Fixed month="JUNE" day="16" descriptionPropertiesKey="christian.CORPUS_CHRISTI"/>
+      <Fixed month="AUGUST" day="15" descriptionPropertiesKey="ASSUMPTION_DAY"/>
       <Fixed month="NOVEMBER" day="1" descriptionPropertiesKey="ALL_SAINTS"/>
     </Holidays>
-    <SubConfigurations hierarchy="mu" description="München">
-      <Holidays>
-        <Fixed month="AUGUST" day="15" descriptionPropertiesKey="ASSUMPTION_DAY"/>
-      </Holidays>
-    </SubConfigurations>
     <SubConfigurations hierarchy="ag" description="Augsburg">
       <Holidays>
         <Fixed month="AUGUST" day="8" descriptionPropertiesKey="PEACE"/>
-        <Fixed month="AUGUST" day="15" descriptionPropertiesKey="ASSUMPTION_DAY"/>
-      </Holidays>
-    </SubConfigurations>
-    <SubConfigurations hierarchy="wu" description="Würzburg">
-      <Holidays>
-        <Fixed month="AUGUST" day="15" descriptionPropertiesKey="ASSUMPTION_DAY"/>
-      </Holidays>
-    </SubConfigurations>
-    <SubConfigurations hierarchy="re" description="Regensburg">
-      <Holidays>
-        <Fixed month="AUGUST" day="15" descriptionPropertiesKey="ASSUMPTION_DAY"/>
-      </Holidays>
-    </SubConfigurations>
-    <SubConfigurations hierarchy="in" description="Ingolstadt">
-      <Holidays>
-        <Fixed month="AUGUST" day="15" descriptionPropertiesKey="ASSUMPTION_DAY"/>
       </Holidays>
     </SubConfigurations>
   </SubConfigurations>

diff --git a/jollyday-tests/src/test/resources/holidays/Holidays_test_de_2023.xml b/jollyday-tests/src/test/resources/holidays/Holidays_test_de_2023.xml
@@ -37,32 +37,12 @@
     <Holidays>
       <Fixed month="JANUARY" day="6" descriptionPropertiesKey="EPIPHANY"/>
       <Fixed month="JUNE" day="8" descriptionPropertiesKey="christian.CORPUS_CHRISTI"/>
+      <Fixed month="AUGUST" day="15" descriptionPropertiesKey="ASSUMPTION_DAY"/>
       <Fixed month="NOVEMBER" day="1" descriptionPropertiesKey="ALL_SAINTS"/>
     </Holidays>
-    <SubConfigurations hierarchy="mu" description="München">
-      <Holidays>
-        <Fixed month="AUGUST" day="15" descriptionPropertiesKey="ASSUMPTION_DAY"/>
-      </Holidays>
-    </SubConfigurations>
     <SubConfigurations hierarchy="ag" description="Augsburg">
       <Holidays>
         <Fixed month="AUGUST" day="8" descriptionPropertiesKey="PEACE"/>
-        <Fixed month="AUGUST" day="15" descriptionPropertiesKey="ASSUMPTION_DAY"/>
-      </Holidays>
-    </SubConfigurations>
-    <SubConfigurations hierarchy="wu" description="Würzburg">
-      <Holidays>
-        <Fixed month="AUGUST" day="15" descriptionPropertiesKey="ASSUMPTION_DAY"/>
-      </Holidays>
-    </SubConfigurations>
-    <SubConfigurations hierarchy="re" description="Regensburg">
-      <Holidays>
-        <Fixed month="AUGUST" day="15" descriptionPropertiesKey="ASSUMPTION_DAY"/>
-      </Holidays>
-    </SubConfigurations>
-    <SubConfigurations hierarchy="in" description="Ingolstadt">
-      <Holidays>
-        <Fixed month="AUGUST" day="15" descriptionPropertiesKey="ASSUMPTION_DAY"/>
       </Holidays>
     </SubConfigurations>
   </SubConfigurations>