Typo in NYSE-EURONEXT and missing in HolidayCalendar enum (#453)

* no sure if on purpose or a type/missing But nyse_euronext xml config file has a typo, nsye_euronext.xml And also nyse_euronext is missing from the HoldayCalendar Enum * use old import order * use old import order --------- Co-authored-by: Gandulf Kohlweiss <[email protected]>
focus-shift · Feb 9, 2024 · b0ce1fd · b0ce1fd
1 parent 34c89f2
commit b0ce1fd
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 3 deletions.
diff --git a/jollyday-core/src/main/java/de/focus_shift/jollyday/core/HolidayCalendar.java b/jollyday-core/src/main/java/de/focus_shift/jollyday/core/HolidayCalendar.java
@@ -22,7 +22,7 @@ public enum HolidayCalendar {
   KAZAKHSTAN("KZ"), KOSOVO("XK"),
   LATVIA("LV"), LIECHTENSTEIN("LI"), LITHUANIA("LT"), LONDON_METAL_EXCHANGE("LME"), LUXEMBOURG("LU"),
   MACEDONIA("MK"), MALTA("MT"), MAURITIUS("MU"), MEXICO("MX"), MOLDOVA("MD"), MONTENEGRO("ME"),
-  NETHERLANDS("NL"), NEW_ZEALAND("NZ"), NICARAGUA("NI"), NIGERIA("NG"), NORWAY("NO"), NYSE("NYSE"),
+  NETHERLANDS("NL"), NEW_ZEALAND("NZ"), NICARAGUA("NI"), NIGERIA("NG"), NORWAY("NO"), NYSE("NYSE"), NYSE_EURONEXT("NYSE_EURONEXT"),
   PANAMA("PA"), PARAGUAY("PY"), PERU("PE"), POLAND("PL"), PORTUGAL("PT"),
   ROMANIA("RO"), RUSSIA("RU"),
   SAUDI_ARABIA("SA"), SERBIA("RS"), SINGAPORE("SG"), SLOWAKIA("SK"), SLOWENIA("SI"), SOUTH_AFRICA("ZA"), SPAIN("ES"), SWEDEN("SE"), SWITZERLAND("CH"),

diff --git a/...urces/holidays/Holidays_nsye_euronext.xml → ...urces/holidays/Holidays_nyse_euronext.xml b/...urces/holidays/Holidays_nsye_euronext.xml → ...urces/holidays/Holidays_nyse_euronext.xml
diff --git a/jollyday-core/src/test/java/de/focus_shift/jollyday/core/HolidayCalendarTest.java b/jollyday-core/src/test/java/de/focus_shift/jollyday/core/HolidayCalendarTest.java
@@ -11,7 +11,7 @@
 
 class HolidayCalendarTest {
 
-  private static final List<String> noneIso3166Countries = List.of("DJ_STOXX", "LME", "NYSE", "TARGET", "XK");
+  private static final List<String> noneIso3166Countries = List.of("DJ_STOXX", "LME", "NYSE", "NYSE_EURONEXT", "TARGET", "XK");
 
   @Test
   void ensureThatAllCountryAreISO3166Conform() {

diff --git a/jollyday-tests/src/test/java/de/focus_shift/jollyday/tests/CalendarHierarchyTest.java b/jollyday-tests/src/test/java/de/focus_shift/jollyday/tests/CalendarHierarchyTest.java
@@ -19,7 +19,7 @@
 
 class CalendarHierarchyTest {
 
-  private static final List<String> noneIso3166Countries = List.of("DJ_STOXX", "LME", "NYSE", "TARGET", "XK", "FR");
+  private static final List<String> noneIso3166Countries = List.of("DJ_STOXX", "LME", "NYSE", "NYSE_EURONEXT", "TARGET", "XK", "FR");
   private static final List<String> okSubdivisions = List.of("FI-01", "ES-RI", "IN-DH", "IN-OD", "IN-UK", "IN-CG", "IN-LA", "IN-TS");
 
   @Test