Skip to content

Commit

Permalink
Update 001-document-every-subdivision.md
Browse files Browse the repository at this point in the history
  • Loading branch information
derTobsch authored Feb 23, 2024
1 parent b62b67d commit d931135
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions .adr/001-document-every-subdivision.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ Accepted

## Context

This decision arises from the discussion on https://github.com/focus-shift/jollyday/pull/388, where the identification for subdivisions was changed to 'ISO 3166-2'. There was uncertainty regarding whether to include subdivisions that do not have additional holidays compared to the country.
This decision arises from the discussion on https://github.com/focus-shift/jollyday/pull/388, where the identification for subdivisions was changed to 'ISO 3166-2'.
There was uncertainty regarding whether to include subdivisions that do not have additional holidays compared to the country.

During the discussion, it was noted that having numerous subdivisions for a country like India while missing a few could lead to confusion and require significant time investment to identify the missing ones.

Expand All @@ -16,10 +17,10 @@ The decision has been made to include all subdivisions, regardless of whether th

## Consequences

For subdivisions without separate public holidays, an empty `SubConfigurations` will still be created. For instance, for `Ladākh`, it will appear as follows in the configuration:
For subdivisions without separate holidays, an empty `SubConfigurations` will still be created. For example, for `Ladākh`, it will appear as follows in the configuration:

```xml
<SubConfigurations hierarchy="la" description="Ladākh">
<SubConfigurations hierarchy="la" description="Ladākh">
<Holidays/>
</SubConfigurations>
```
Expand Down

0 comments on commit d931135

Please sign in to comment.