-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade mime-types to 3.0 #439
Conversation
@geemus please let me know what you think! |
Authored-by: Seth Boyles <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable to me.
Unfortunately I haven't been following closely, as I don't recall if I've ever directly used azure myself. Looks like some of the folks that had been more actively maintaining may have drifted away, so help in catching up and closing out old issues would certainly be welcome also.
@sethboyles - I would imagine this probably warrants a release also? |
thanks for the expedient merge! A release will not be immediately helpful for us working on Cloud Foundry (as this is just a step towards merging our branch in to master), but I think it would be helpful for the others that have been waiting for this. And then of course those related issues could be closed, too. The fog-arm-cf branch might address some of those other issues; when I open a PR to merge that into master I will do some digging and see what issues it might address. |
Released in v0.6.0, we'll probably need to clean up issues still, any aide you could give would be great. |
@geemus I would be happy to clean up issues but I don't have permission to close them. Shall I just ping you in the ones I think are relevant? |
@sethboyles Oops, right. That should be fine for now, thanks. |
This PR upgrades mime-types, no longer restricting it to be an old version
1.25
mime-types
1.x has been out of support since 20152.x has been out of support since 2017.
This dependencies causes several issues, from #390, #359, to being unable to support #367 in master.
Previously, in #367, the reason given for not updating the mime-types dependency was that another (seemingly unrelated, except that in that it consumes this gem) app, OneOps, relied on mime-types 1.x. That app itself is not supported anymore.
We would love to have this merged in so we can eventually stop maintaining our own separate branch
fog-arm-cf
and contribute to the main release.Thanks,
Seth