Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an exception for the missing storage field #294

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

girijaasoni
Copy link
Contributor

This is a proposed solution for #2186114
I think creating a host without mentioning the storage pod or the datastore should not be permitted. Adding validation is one way to go but achieving that is extremely difficult. Adding an exception is a much simpler approach to it.

I'm open for any other ideas to approach this problem. Please feel free to share your thoughts on this.
cc: @ShimShtein

@girijaasoni girijaasoni changed the title Add an exception for themissing storage field Add an exception for the missing storage field Mar 26, 2024
@chris1984 chris1984 self-assigned this Mar 26, 2024
@ShimShtein
Copy link

A bit of context: currently the system does not allow empty storage field, and fails the creation of a VM with "Invalid path" error, which is not indicative at all.

Copy link
Collaborator

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise it looks fine, will start testing

@ShimShtein
Copy link

LGTM code-wise.

Copy link
Collaborator

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine on my devel box, ACK. Will get a new release made. Thanks @girijaasoni

@chris1984 chris1984 merged commit 3ab7712 into fog:master Apr 10, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants