Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missed rerecorded tests from 'Add disk and partitions info' #297

Merged
merged 1 commit into from
May 2, 2024

Conversation

dosas
Copy link
Contributor

@dosas dosas commented Apr 30, 2024

c6b1347

In #284

          disks: 'config.hardware.device',
          partitions:  'guest.disk',

was added but the tests were not adapted accordingly.

This was not noticed because the CI is broken since quite some time. (see also #296)

CC: @Manisha15 @sbernhard

@chris1984
Copy link
Collaborator

@dosas can you rebase so it pulls in your other pr?

@chris1984 chris1984 self-assigned this Apr 30, 2024
@dosas dosas force-pushed the fixup-add-info branch from f051379 to 4c30cdc Compare May 2, 2024 06:20
@dosas
Copy link
Contributor Author

dosas commented May 2, 2024

@dosas can you rebase so it pulls in your other pr?

Done

@dosas
Copy link
Contributor Author

dosas commented May 2, 2024

The test that is still failing should be fixed here: #298

@chris1984 chris1984 merged commit 070827a into fog:master May 2, 2024
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants