Added functionality to get time series graph for Assets reading [FOGL-1524] #323

MonikaSharma06 · 2018-10-04T12:28:53Z

No description provided.

praveen-garg

Need to fix series vs other names like readings/ average. And also need to check do we want a link text button to open time series graph? and where to place it in gui!

praveen-garg · 2018-10-04T13:03:06Z

src/app/components/core/asset-readings/series-graph/series-graph.component.html

+              <span class="tag is-light"> Min </span>
+              <span class="tag is-info" [ngStyle]="{'background-color': '#85C1E9'}">{{roundTo(reading.min, 5)}}</span>
+              &nbsp;
+              <span class="tag is-light"> Max </span>


I don;t think we need avg,min max here

praveen-garg · 2018-10-04T13:03:22Z

src/app/components/core/asset-readings/series-graph/series-graph.component.ts

+  public assetReadingSummary = [];
+  public graphRefreshInterval = POLLING_INTERVAL;
+  public optedGroup = 'seconds';
+  public readKeyColorLabel = [];


are these all variables required?

praveen-garg · 2018-10-04T13:03:42Z

src/app/components/core/asset-readings/series-graph/series-graph.component.ts

+  constructor(private assetService: AssetsService, private alertService: AlertService,
+    private ping: PingService) {
+    this.assetChartType = 'line';
+    this.assetReadingValues = [];


assetReadings?

praveen-garg · 2018-10-04T13:04:08Z

src/app/components/core/asset-readings/series-graph/series-graph.component.ts

+    }
+    this.assetCode = assetCode;
+    if (autoRefresh === false) {
+      this.plotReadingsGraph(assetCode);


plotReadingsGraph?

praveen-garg · 2018-10-04T13:04:46Z

src/app/components/core/asset-readings/series-graph/series-graph.component.ts

+    this.statsAssetSeriesGraph(assetTimeLabels, assetReading);
+  }
+
+  getColorCode(readKey, cnt, fill) {


looks it will be util function

praveen-garg · 2018-10-04T13:05:37Z

src/app/services/assets.service.ts

-  public getAssetAverage(assetObject: any) {
-    // TODO: time based readings average;
-    return this.http.get(this.GET_ASSET + '/' + encodeURIComponent(assetObject.assetCode) + '/' + assetObject.reading + '/series').pipe(
+  public getAssetAverage(assetCode: string, reading: string, group) {


mshariq-nerd · 2018-10-08T09:32:20Z

In case of empty value in time field. foglamp/asset/system%2FcpuUsage%2Fall/%iowait/series?group=seconds&seconds=null throwing error 400 Time must be a positive integer

praveen-garg

I don't see default set to 10 minutes. and no loading indicator on first time load of an asset/sensor

mshariq-nerd

ERROR: /foglamp-gui/src/app/components/core/asset-readings/series-graph/series-graph.component.ts[2, 1]: All imports on this line are unused.

Lint errors found in the listed file.

mshariq-nerd · 2018-10-08T09:59:55Z

src/app/components/core/asset-readings/series-graph/series-graph.component.ts

+      });
+  }
+
+  public getAssetReadingsSummary(assetCode) {


getAssetReadingsSummary? or Series?

mshariq-nerd · 2018-10-08T10:00:53Z

src/app/components/core/asset-readings/series-graph/series-graph.component.ts

+  }
+
+  public getAssetReadingsSummary(assetCode) {
+    this.assetService.getAllAssetSummary(assetCode).subscribe(


getAllAssetSummary => getAllAssetSeries ?

mshariq-nerd · 2018-10-08T10:01:12Z

src/app/components/core/asset-readings/series-graph/series-graph.component.ts

+  public getAssetReadingsSummary(assetCode) {
+    this.assetService.getAllAssetSummary(assetCode).subscribe(
+      (data: any) => {
+        this.assetReadingSummary = data.map(o => {


change summary by series

mshariq-nerd · 2018-10-08T10:01:31Z

src/app/components/core/asset-readings/series-graph/series-graph.component.ts

+            value: [o[k]]
+          };
+        });
+        this.assetReadingSummary = orderBy(this.assetReadingSummary, ['name'], ['asc']);


mshariq-nerd · 2018-10-10T13:55:38Z

Still seeing this issue
for blank value in input field

foglamp/asset/system%2FcpuUsage%2Fall/%iowait/series?group=seconds&seconds=null

throwing error 400 Time must be a positive integer

mshariq-nerd · 2018-10-11T12:38:09Z

@billehunt This PR is ready for final review. You can test it with FogLAMP develop branch

praveen-garg · 2018-10-11T18:47:15Z

src/app/components/core/asset-readings/series-graph/series-graph.component.html

+          <circle class="path" cx="50%" cy="50%" r="10" fill="none" stroke-width="2" stroke-miterlimit="10" />
+        </svg>
+      </div>
+      <div *ngIf='!showSpinner && showGraph' class="columns is-mobile">


we should remove showGraph from here?
As this is being set on ReadingsValidator.validate(data); so if data for grpah is not numeric, allow user to select asset/sensor to fetch series for newly selected item

praveen-garg · 2018-10-11T18:47:59Z

src/app/utils.ts

@@ -80,6 +80,25 @@ export default class Utils {
    return totalSec < 0 || totalSec >= 86400;
  }

+  public static getColorCode(readKey, cnt) {


as we have it in Utils, can we remove the copy for readings graph and use this itself.

mshariq-nerd · 2018-10-12T12:23:15Z

@billehunt Please check the below screenshot to see how asset average graph is rendering on asset click

billehunt · 2018-10-12T15:59:21Z

I'm afraid this functionality is not useful. Users don't need a graph of min/max/average over time.

Please don't add any graphs without having me in the loop.

praveen-garg · 2018-10-12T16:02:14Z

Closing as not required!

billehunt · 2018-10-12T16:31:05Z

Actually, I think I jumped the gun with my last comment. My assumption was that this was for the ongoing min, max and average (as the graph above in this PR shows). But now that I'm running the code, I see you're actually looking at min/max/avg for each of the time slices displayed. Which is really good, in fact, way better than what I was thinking (just an avg for each data point).

Please re-open and let's discuss next steps with this. I think you're on a good path. Maybe we shouldn't be showing 3 lines, but rather something like this: https://www.researchgate.net/profile/Ian_C_Dunican/publication/311517204/figure/fig4/AS:667673046294537@1536197067559/Between-conditions-comparison-of-max-distance-m-run-displaying-the-group-average.png

Sorry about that.

MonikaSharma06 added 2 commits October 4, 2018 17:23

initial commit

3f47fbd

added time series graph for asset reading

d31724d

MonikaSharma06 added the IN PROGRESS label Oct 4, 2018

praveen-garg suggested changes Oct 4, 2018

View reviewed changes

praveen-garg requested a review from mshariq-nerd October 4, 2018 13:07

MonikaSharma06 added 2 commits October 5, 2018 17:29

changes done as per feedback

2fed6fe

added input box to enter time

9d3f87a

show graph individually by selecting a asset reading key

e2e9668

MonikaSharma06 removed the IN PROGRESS label Oct 9, 2018

changes as per feedback

581d61e

praveen-garg suggested changes Oct 9, 2018

View reviewed changes

mshariq-nerd reviewed Oct 10, 2018

View reviewed changes

MonikaSharma06 added 4 commits October 11, 2018 15:27

fixed lint error and null input value of time

4aee901

fixed issues

a973f9a

removed commented line of code

153a41d

fixed issue due to time value having space

418f876

mshariq-nerd previously approved these changes Oct 11, 2018

View reviewed changes

mshariq-nerd requested a review from billehunt October 11, 2018 12:36

praveen-garg suggested changes Oct 11, 2018

View reviewed changes

changes done as per feedback

16f2974

MonikaSharma06 dismissed mshariq-nerd’s stale review via 16f2974 October 12, 2018 08:02

fixed issue

48901c7

praveen-garg approved these changes Oct 12, 2018

View reviewed changes

mshariq-nerd approved these changes Oct 12, 2018

View reviewed changes

Merge branch 'develop' into FOGL-1524

acd33f4

praveen-garg closed this Oct 12, 2018

praveen-garg reopened this Oct 12, 2018

MonikaSharma06 added 3 commits October 26, 2018 16:38

Merge branch 'develop' into FOGL-1524

25f3610

Merge branch 'develop' into FOGL-1524

8bd860d

Merge branch 'develop' into FOGL-1524

94c6fe5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added functionality to get time series graph for Assets reading [FOGL-1524] #323

Added functionality to get time series graph for Assets reading [FOGL-1524] #323

MonikaSharma06 commented Oct 4, 2018

praveen-garg left a comment

praveen-garg Oct 4, 2018

praveen-garg Oct 4, 2018

praveen-garg Oct 4, 2018

praveen-garg Oct 4, 2018

praveen-garg Oct 4, 2018

praveen-garg Oct 4, 2018

mshariq-nerd commented Oct 8, 2018

praveen-garg left a comment

mshariq-nerd left a comment •

edited

Loading

mshariq-nerd Oct 8, 2018

mshariq-nerd Oct 8, 2018

mshariq-nerd Oct 8, 2018

mshariq-nerd Oct 8, 2018

mshariq-nerd commented Oct 10, 2018

mshariq-nerd commented Oct 11, 2018

praveen-garg Oct 11, 2018

praveen-garg Oct 11, 2018

mshariq-nerd commented Oct 12, 2018

billehunt commented Oct 12, 2018

praveen-garg commented Oct 12, 2018

billehunt commented Oct 12, 2018

Added functionality to get time series graph for Assets reading [FOGL-1524] #323

Are you sure you want to change the base?

Added functionality to get time series graph for Assets reading [FOGL-1524] #323

Conversation

MonikaSharma06 commented Oct 4, 2018

praveen-garg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mshariq-nerd commented Oct 8, 2018

praveen-garg left a comment

Choose a reason for hiding this comment

mshariq-nerd left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mshariq-nerd commented Oct 10, 2018

mshariq-nerd commented Oct 11, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mshariq-nerd commented Oct 12, 2018

billehunt commented Oct 12, 2018

praveen-garg commented Oct 12, 2018

billehunt commented Oct 12, 2018

mshariq-nerd left a comment •

edited

Loading