This repository has been archived by the owner on Mar 23, 2020. It is now read-only.
FOGL-2534: Fix of sidebar visibility issue on manual url re-routing #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveen-garg
approved these changes
Feb 25, 2019
praveen-garg
suggested changes
Feb 25, 2019
praveen-garg
suggested changes
Feb 26, 2019
There was a problem hiding this comment.
I suggest to break this PR into 2. first PR should have changes for
footer/footer.component.html to fix version issue only.
Recent commit/s fix the sidebar issue, but Setup Instance does not redirect to Settings page and traffic light hover shows empty popup.
mshariq-nerd
changed the title
mshariq-nerd
changed the title
praveen-garg
previously approved these changes
Feb 26, 2019
MonikaSharma06
previously approved these changes
Feb 26, 2019
mshariq-nerd
dismissed stale reviews from MonikaSharma06 and praveen-garg
via
8224c01
praveen-garg
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR need to be tested with
auth mandatorymode as well. I have change some url re-routing code. This will fix manual re-routing