Skip to content
This repository has been archived by the owner on Mar 23, 2020. It is now read-only.

FOGL-3062: Update GUI to use new bucket API for asset graphs #551

Open
wants to merge 103 commits into
base: develop
Choose a base branch
from

Conversation

mshariq-nerd
Copy link
Contributor

@mshariq-nerd mshariq-nerd commented Dec 5, 2019

Current Data Mode

  • Zoom In (based on defined window sized calculation)
  • Zoom Out (based on defined window sized calculation)

Historic Data Mode (Pan Mode)

  • Pan to the Past (Drag Right)
  • ZoomIn
  • ZoomOut

Note: This graph functionality is done using the Plotly.js library that we are already using for 3D graph. Plotly.js implicitly provide this Zoom facility.

payload = {
assetCode: '',
start: 0,
len: 600,
Copy link
Contributor

@MonikaSharma06 MonikaSharma06 Jan 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to put 600, i.e. Max Datapoints, in a variable and use that variable throughout the file.

return a.key > b.key ? -1 : (b.key > a.key ? 1 : 0);
panModeZoom(zoomOut = false) {
// <Start> =(previous Start) + (previous Timespan in seconds) / 2 - (new Timespan in seconds) /2
console.log('lateset payload', this.payload);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lateset -> last OR previous

@MarkRiddoch
Copy link
Contributor

MarkRiddoch commented Jan 21, 2020

Some observations on the pan and zoom functionality

  • Performance is poor, due I suspect to the underlying queries taking a long time. However it would help if the GUI indicated it was busy waiting for results as it is not obvious currently and it is easy to click again and send up having lots of stored up clicks before seeing any data back.

  • It might be better to start with a smaller view on the data as it takes a long time to get the initial screen

  • It is possible to zoom the graph to the future, the really doesn't have any meaning and it would probably aid usability if this was removed.

  • I often get left with a blank, unresponsive screen. I guess because it is waiting for data. Can we keep the previous view until the new data is ready? Combine this with busy feedback and it would probably prevent the user clicking wildly, storing up more refreshing and never seeing anything.

As it stands I don't think this is really usable with any volume of data.

On revisiting this is seems that smaller volumes of data work much better. As soon as you have high bandwidth data things become difficult. I suspect this is down to the volume of data and the time the queries are taking. There may be nothing we can do currently with this, it may also be the case that this is actually still true with the old graph mechanism. It is also probably true that most of our current user base do not have high bandwidth data, so maybe we can go with this on those grounds.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants