-
Notifications
You must be signed in to change notification settings - Fork 6
FOGL-3062: Update GUI to use new bucket API for asset graphs #551
base: develop
Are you sure you want to change the base?
Conversation
Changed rangemode of graph on dashboard
payload = { | ||
assetCode: '', | ||
start: 0, | ||
len: 600, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to put 600, i.e. Max Datapoints, in a variable and use that variable throughout the file.
return a.key > b.key ? -1 : (b.key > a.key ? 1 : 0); | ||
panModeZoom(zoomOut = false) { | ||
// <Start> =(previous Start) + (previous Timespan in seconds) / 2 - (new Timespan in seconds) /2 | ||
console.log('lateset payload', this.payload); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lateset -> last OR previous
Some observations on the pan and zoom functionality
As it stands I don't think this is really usable with any volume of data. On revisiting this is seems that smaller volumes of data work much better. As soon as you have high bandwidth data things become difficult. I suspect this is down to the volume of data and the time the queries are taking. There may be nothing we can do currently with this, it may also be the case that this is actually still true with the old graph mechanism. It is also probably true that most of our current user base do not have high bandwidth data, so maybe we can go with this on those grounds. |
Current Data Mode
Historic Data Mode (Pan Mode)
Note: This graph functionality is done using the Plotly.js library that we are already using for 3D graph. Plotly.js implicitly provide this Zoom facility.