Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retries to S3 GetChunk and PutChunk #176

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

Joe-Improbable
Copy link
Contributor

This PR should solve (or at least significantly reduce the chance of) #175

It changes the S3 store to also respect the error-retry option and retry any failed GET or PUT requests

@folbricht folbricht merged commit f633626 into folbricht:master Oct 29, 2020
@folbricht
Copy link
Owner

Thank you. I'm wondering if longer-term it'd be better to use a wrapper that implements the Store interface to do the retries, rather than having it in every store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants