Use cloneDeep() to make diagramOptions immutable #765
Conversation
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-002d75103-765.westeurope.2.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-002d75103-765.westeurope.2.azurestaticapps.net |
|
|
||
| @if (diagramOptions.description) { | ||
| <p class="mb-4">{{ diagramOptions.description }}</p> | ||
| @if (diagramOptionsInternal.description) { |
There was a problem hiding this comment.
Created a new issue to handle this: #768
| @@ -1,8 +1,8 @@ | |||
| <article *ngIf="diagramOptions !== undefined"> | |||
| <h1 class="h3 mb-3">{{ diagramOptions.title }}</h1> | |||
| <article *ngIf="diagramOptionsInternal !== undefined"> | |||
There was a problem hiding this comment.
@proand The user might send diagramOption as null. Maybe change diagramOptionsInternal !== undefined
@if(diagramOptionsInternal) or
@if(diagramOptionsInternal != null) or
@if(diagramOptionsInternal !== null && diagramOptionsInternal !== undefined)
There was a problem hiding this comment.
I have a little list (not exhaustive) of values, or missing values, in the diagramOptions that can give errors in current implementation. I'm pondering making a test of the input, and then jsut test for !diagramOptionsValid or something like that... but probably best to create an issue for that, and go for your solution now.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-002d75103-765.westeurope.2.azurestaticapps.net |
* dev: Enhancement/highcharts category axis title (#763) Update CHANGELOG Fix selected value not visible before ng-select is touched
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-002d75103-765.westeurope.2.azurestaticapps.net |
* dev: Update qualitative series in _all.scss (#771)
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-002d75103-765.westeurope.2.azurestaticapps.net |
This closes #753