Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/tree view selection search #769

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Enhancement/tree view selection search #769

wants to merge 12 commits into from

Conversation

proand
Copy link
Member

@proand proand commented Dec 13, 2024 •
edited
Loading

This closes #739

Bernt Andersen added 4 commits December 3, 2024 14:57
Make the search work on keydown, and start at first character
4152722
Some refactorings
738dd62
Update README
242ecd1
Add POC of searchTerm with debounceTime
53c6817 
  - Update template
  - Skip use of keyup
  - Update the code doing the filtering
  - Add scrollbar and remove old code
  - Update demo
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-002d75103-769.westeurope.2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-002d75103-769.westeurope.2.azurestaticapps.net

Add resetFilter(), remove logs
77b644c 
PS. The "backspace bug" is still not solved...
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-002d75103-769.westeurope.2.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-002d75103-769.westeurope.2.azurestaticapps.net

Bernt Andersen added 2 commits December 18, 2024 13:20
Merge branch 'dev' into enhancement/tree-view-selection-search
22569d8 
* dev:
  FhiAngularHighcharts: Use cloneDeep() to make diagramOptions immutable (#765)
  Update qualitative series in _all.scss (#771)
  Enhancement/highcharts category axis title (#763)
  Update CHANGELOG
  Fix selected value not visible before ng-select is touched
Update CHANGELOG
aca4e5a
@proand proand marked this pull request as ready for review December 18, 2024 12:23
@proand proand requested a review from robinzaal December 18, 2024 12:23
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-002d75103-769.westeurope.2.azurestaticapps.net

robinzaal
robinzaal reviewed Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@robinzaal robinzaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@proand

Burde man kanskje ivareta mulighet til å kunne "Velg alle" og åpne/lukke kategorier etter man har gjort et søk?

image

@proand
Copy link
Member Author

proand commented Dec 20, 2024 •
edited
Loading

Burde man kanskje ivareta mulighet til å kunne "Velg alle" og åpne/lukke kategorier etter man har gjort et søk?

@robinzaal Jeg er enig i at resultatlisten ikke er optimal slik den er nå, men det er utenfor scope for dette issuet.

PS. Jeg ser også litt på bedre måter å rendre listen på, slik at ikke browser fryser, og en dermed ikke trenger å legge til 400ms med venting, og heller ingen spinner, men jeg tenker at det ikke kommer med nå, men blir en del av neste iterasjon av løsningen. I neste iterasjonen kan designere med hell også forbedre resultatlisten 😉

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://nice-bush-002d75103-769.westeurope.2.azurestaticapps.net

@robinzaal robinzaal self-requested a review December 20, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinzaal robinzaal robinzaal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Søk i Treeview komponent: Man må kunne søke med færre enn 3 tegn
2 participants
@proand @robinzaal